Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the font set in settings to certain output text boxes #536

Merged
merged 1 commit into from
May 27, 2022

Conversation

bladedeyna
Copy link
Contributor

@bladedeyna bladedeyna commented May 21, 2022

Allows the selected font in the settings to be applied to areas that makes sense, for example selecting a fixed width font would make the output content easier to read.

The following tools have this applied:

  • The UUID Generator output
  • The Hash Generator hash outputs
  • Regex tester - regex string textbox

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Currently the output textbox uses the default Windows font (Segoe UI) which not a fixed width font. It is not currently possible to change this font during application use.

Issue Numbers: #153 & #290

What is the new behavior?

  • CustomTextBox now takes note of the Font setting via the SettingsProvider. This allows various controls to inherit and bind to this setting.

Other information

Screenshot showing the default font Segoe UI which cannot be changed by the settings
image

Screenshot showing the applied font (Cascadia Mono)
image

Screenshot showing that the font could also be changed to another fixed width font (Consolas in this case)
image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution! :)

@veler veler merged commit b090f75 into DevToys-app:main May 27, 2022
@bladedeyna bladedeyna deleted the fixed_width branch May 28, 2022 10:26
veler pushed a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can set output with sepecified font ? Output fields do not have fixed width font
2 participants