-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add xml validation tool #525
Conversation
Hi, |
Hi Etienne! |
eae490a
to
0ad37bb
Compare
Alright, so the app should start now - sorry for the inconvenience! |
Thank you :) Unfortunately I still see a merge conflict indicated by GitHub. It looks like your branch doesn't have the last changes from the |
0ad37bb
to
d1be28e
Compare
...one noob mistake after another .XD |
Hello, So sorry for the late answer. Wow, it's been 15 days already >.< I gave a try to your pull request and overall, I love it! :D It's such a great tool and great execution! One thing that bother me is the UI, but I can provide some guidance for it 😉
What do you think? 😊 Thank you, and sorry again for the late answer. Please let me know if you have any question. |
Hi Etienne! |
That sounds great to me! :D Enjoy your vacation, and thank you again for your contribution! |
Hi Etienne! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 😊
Thank you for the update. Very great progress overall! It feels almost ready for production!
I left some additional comments. Please let me know if you have any question or need any help.
Thank you again for this contribution, I'm excited to see this in DevToys 😁🥳
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/Parsing/ParsingResultBase.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/XmlValidatorToolViewModel.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/Text/XmlValidator/XmlValidatorToolViewModel.cs
Show resolved
Hide resolved
src/dev/impl/DevToys/Views/Tools/Text/XmlValidator/XmlValidatorToolPage.xaml
Show resolved
Hide resolved
Hi Etienne! |
The introduced tool allows to validate XML data against a XSD schema. Refs: DevToys-app#171
f55c5fb
to
5144b5d
Compare
Hi Etienne, P.S.: Rebased the latest changes from |
Ah, and don't be confused - I just updated my username and picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks all great now! Thank you so much for offering this new tool. It will be shipped in the next update 🎉😁
src/dev/impl/DevToys/Views/Tools/Text/XmlValidator/XmlValidatorToolPage.xaml
Show resolved
Hide resolved
Awesome! |
* feat: add xml validation tool The introduced tool allows to validate XML data against a XSD schema. Refs: #171 * fix: revert manifest changes * fix: remove 'validate' button * feat: use standard info dialog * chore: delete unused assets * refactor: delete unused code * feat: add new tool icon * feat: add 'enable nullable' directive * feat: adjust accessibility levels * refactor: apply code convention * feat: display info bar at startup * fix: adjust overlay view layout * feat: support SmartDetection * fix: validation execution * fix: remove unnecessary localization Co-authored-by: davidTigris <[email protected]> Co-authored-by: davidTigris <davidTigris [email protected]>
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently there is no tool available in DevToys to enable a developer to validate XML data against a XSD schema.
Issue Number: #171
What is the new behavior?
XmlValidator
tool page was createdOther information
Quality check
Before creating this PR, have you: