Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 469 - Checksum/Hash generator doesn't accept empty file/input #493

Merged
merged 2 commits into from
Apr 16, 2022

Conversation

L1nu5
Copy link
Contributor

@L1nu5 L1nu5 commented Apr 14, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #469

What is the new behavior?

Empty file can now have checksums generated:

  1. MD5: d41d8cd98f00b204e9800998ecf8427e
  2. SHA1: da39a3ee5e6b4b0d3255bfef95601890afd80709
  3. SHA256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
  4. SHA384: 38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b
  5. SHA512: cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e

Other information

Tested on Windows 10 21H2, x64 (Release and Debug)

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

Updated the unit tests for Hashing functions when the input is an empty file/empty string.
@veler veler linked an issue Apr 16, 2022 that may be closed by this pull request
@veler
Copy link
Collaborator

veler commented Apr 16, 2022

Hello,
That looks great! Thank you for your contribution :)

@veler veler merged commit f6c230c into DevToys-app:main Apr 16, 2022
@L1nu5 L1nu5 deleted the fix-469 branch April 17, 2022 06:55
veler pushed a commit that referenced this pull request Mar 31, 2023
…493)

* Fixes 469 - Checksum/Hash generator doesn't accept empty file/input

* Fixed unit tests required to fix issue 469

Updated the unit tests for Hashing functions when the input is an empty file/empty string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum/Hash generator doesn't accept empty file/input
3 participants