Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error when the textbox of NumberBaseConverter is empty. #414

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

niyari
Copy link
Contributor

@niyari niyari commented Feb 19, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Fixed a bug in NumberBaseConverter that caused DevToys to quit when switching focus when the text box was empty.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler
Copy link
Collaborator

veler commented Feb 21, 2022

Thank you for this! :)

@veler veler merged commit f1ead2d into DevToys-app:main Feb 21, 2022
@niyari niyari deleted the fix-nb-conv branch February 21, 2022 18:07
@niyari niyari mentioned this pull request Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants