Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in exception handler #253

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Fixed typo in exception handler #253

merged 4 commits into from
Jan 25, 2022

Conversation

youkai95
Copy link
Contributor

Pull request type

Fixed typo in JsonToYaml exception handler.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@youkai95
Copy link
Contributor Author

I have not noticed the merge commits in my fork history. If you do not want them in project history, close the pull and I will open a fresh one.

@veler
Copy link
Collaborator

veler commented Jan 25, 2022

Thank you for your change :) That's a good catch!

@veler veler merged commit 8b7fcdf into DevToys-app:main Jan 25, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
* Fixing hex validation. "0" was not an accepted hex value

* Typo in exception logger

Co-authored-by: Youkai <Youkai@DESKTOP-897VL99>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants