Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes numbers are converted to string in Yaml to Json conversion #236

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fixes numbers are converted to string in Yaml to Json conversion #236

merged 1 commit into from
Jan 25, 2022

Conversation

akarboush
Copy link
Contributor

@akarboush akarboush commented Jan 24, 2022 •
edited
Loading

Closes #202

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #202

What is the new behavior?

  • numbers are now converted to decimal instead of string

Other information

g

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@akarboush akarboush changed the title Fixes numbers are converted to string in Yaml to Json conversion Fixes numbers are converted to string in Yaml to Json conversion Closes #202 Jan 24, 2022
@akarboush akarboush changed the title Fixes numbers are converted to string in Yaml to Json conversion Closes #202 Fixes numbers are converted to string in Yaml to Json conversion Jan 24, 2022
@veler veler added the bug Something isn't working label Jan 25, 2022
@veler
Copy link
Collaborator

veler commented Jan 25, 2022

hello,
It looks all good, thank you very much for helping at fixing this bug! :D

@veler veler merged commit c2bc223 into DevToys-app:main Jan 25, 2022
@akarboush akarboush deleted the bug/yaml-Json-conversion-numbers-converted-to-strings branch January 25, 2022 07:49
veler pushed a commit that referenced this pull request Mar 31, 2023
@akarboush
Fixes numbers are converted to string in Yaml to Json conversion (#236)
9bf2a96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yaml > Json conversion numbers are converted to strings
2 participants
@akarboush @veler