-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/check sum generator #234
Feature/check sum generator #234
Conversation
Regarding point number 3, seems like it's only in debug mode! |
...impl/DevToys/ViewModels/Tools/Generators/CheckSumGenerator/CheckSumGeneratorToolViewModel.cs
Show resolved
Hide resolved
Apply code review suggestions
...impl/DevToys/ViewModels/Tools/Generators/CheckSumGenerator/CheckSumGeneratorToolViewModel.cs
Outdated
Show resolved
Hide resolved
...impl/DevToys/ViewModels/Tools/Generators/CheckSumGenerator/CheckSumGeneratorToolViewModel.cs
Outdated
Show resolved
Hide resolved
...impl/DevToys/ViewModels/Tools/Generators/CheckSumGenerator/CheckSumGeneratorToolViewModel.cs
Show resolved
Hide resolved
...oys/ViewModels/Tools/Graphic/ColorBlindnessSimulator/ColorBlindnessSimulatorToolViewModel.cs
Show resolved
Hide resolved
src/dev/impl/DevToys/Views/Tools/Generators/CheckSumGenerator/CheckSumGeneratorToolPage.xaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thank you very much for this contribution! Overall, it looks very good. Just a few details here and there. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you for the update! It looks good to me. @btiteux , can you please take a look and merge if it looks good to you too?
Nice! Could you please just take a look at points number 1 and 2? |
Oh sorry I missed that.
It looks good to me. Worst case we can change that later.
That's fine too :) |
} | ||
|
||
_isCalculationInProgress = false; | ||
ShouldDisplayProgress = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm facing a race condition on my machine and I think that this line along with 343 and maybe a few others are the cause.
The scenario I have is:
- Select a file. Computation start. Progress bar is displayed.
- Select another file while the computation of the 1st one isn't done yet.
- In this scenario, the progress bar simply disappear.
I think the race here is that line 343 (with the new file) runs before 356 (with the old file) is executed.
A proper fix is probably to cache the task on line 326 and await it (when not null) right after line 339. Thoughts?
* Add CheckSumGenerator boilerplate files * Add progress loading for the hashing calculation * Refactor compute hash helper * Refactor incorrect variable name * Add HashingHelper unit tests * Update rews files * Add compute hash iterations logic * Short circuit CheckSum if file is null * Disable hashing dropdown while processing Apply code review suggestions * Revert assembly info version * Apply code review changes * Remove ControlsToolKit xaml import
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
As a user, I'd like to be able to calculate the checksum of a file and compare it with a hash value so I'm able to know if the file was modified.
Issue Number: #141
What is the new behavior?
As a user, I'd like to be able to calculate the checksum of a file using multiple hashing algorithms like MD5, SHA1, SHA256, SHA384 or SHA512.
It will display a loading spinner while a file is being hashed unless the file is small, so we don't see the load flicking.
Other information
Quality check
Before creating this PR, have you:
What's missing
I will need some help with the above points, thanks.