Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] added menu bar items for Copy, Cut, Paste, Select All #1329

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jul 22, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1203

What is the new behavior?

After investigation, I found that the ultimate problem is that the app lack of a menu bar with keyboard shortcut associated to commands like Cut, Copy, Paste and Select All. I added these menus and made them doing a copy/paste/cut/select all in the element that has the focus.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler linked an issue Jul 22, 2024 that may be closed by this pull request
@veler veler merged commit 191f3d7 into main Jul 22, 2024
3 checks passed
@veler veler deleted the fix1203-right-fix branch July 22, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MacOS] Paste Shortcut is not working
1 participant