Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Change "Help us translating DevToys" to "Help us translate DevToys" #1308

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

PesBandi
Copy link
Contributor

Change Help us translating DevToys to Help us translate DevToys in the Settings

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

image

What is the current behavior?

Issue Number: #1307

What is the new behavior?

The text is changed to Help us translate DevToys

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler
Copy link
Collaborator

veler commented Jul 17, 2024

Hi,
Please only do the change in Settings.resx and not other languages like Settings.fr-FR.resx. Once merged, Crowdin with synchronize the change and notify translators that something from Settings.resx should be translated.

@PesBandi
Copy link
Contributor Author

Hi, Please only do the change in Settings.resx and not other languages like Settings.fr-FR.resx. Once merged, Crowdin with synchronize the change and notify translators that something from Settings.resx should be translated.

Hi, thank you for the feedback, I didn't realize that. It's changed now.

@veler
Copy link
Collaborator

veler commented Jul 18, 2024

No problem! It looks great now. Thanks for suggesting this change :)

@veler veler merged commit b439eb0 into DevToys-app:main Jul 18, 2024
@PesBandi PesBandi deleted the helptranslating branch July 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants