Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loading indication for Monaco #1260

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Remove loading indication for Monaco #1260

merged 2 commits into from
Jun 25, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 22, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1243

What is the new behavior?

From what I've seen personally and from what customers share on GitHub and social network, Monaco tend to load instantly, and our loading progress indication is more bothering than helpful. Let's remove it completely.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • [] Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler linked an issue Jun 22, 2024 that may be closed by this pull request
@veler veler merged commit 93c9de0 into main Jun 25, 2024
3 checks passed
@veler veler deleted the remove-monaco-loading branch June 25, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

laggy behavior after opening individual tools
1 participant