Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced animation on startup #1227

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Reduced animation on startup #1227

merged 3 commits into from
Jun 18, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 15, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

I got the following conversation on Discord, along with a similar one on Reddit. Basically, DevToys consumes a lot of CPU (8-25%) on the All Tools page because of the animation on the hero background.
 
image

What is the new behavior?

Stop the animation after 2 seconds. I applied a cubic-bezier animation that progressively slows down the animation until it stops, making it smooth.

When the animation stops and that DevToys becomes idle, CPU consumption drops to 0% after ~1 sec.

Recording.2024-06-14.214706.mp4

If complains continue after that, let's completely remove the animation.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler requested a review from btiteux June 15, 2024 04:50
@veler veler merged commit fb096f8 into main Jun 18, 2024
1 of 2 checks passed
@veler veler deleted the reducedanimationonstartup branch June 18, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant