Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows 10 theme #1223

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fixed Windows 10 theme #1223

merged 1 commit into from
Jun 17, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jun 14, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

image

image

Issue Number: #1191

What is the new behavior?

Not perfect but it addresses the emergency:

image

image

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows 10 & 11
    • macOS
    • Linux

@veler veler requested a review from btiteux June 14, 2024 15:46
@veler veler linked an issue Jun 14, 2024 that may be closed by this pull request
@btiteux
Copy link
Collaborator

btiteux commented Jun 15, 2024

I just tested and I have an issue on Windows 11:
image

@veler
Copy link
Collaborator Author

veler commented Jun 15, 2024

I just tested and I have an issue on Windows 11: image

I just checked and it already happening in 2.0.1, so it's not a regression introduced by this PR. Also, you're testing Windows 11 here. The fix I'm doing specifically targets Windows 10.

image

I opened an issue for it here: #1228

I will try to take look at it ASAP :)

@btiteux
Copy link
Collaborator

btiteux commented Jun 15, 2024

I hadn't seen this issue before, so I was not sure. It should be okay for Windows 10, but I don't have a Windows 10 VM to test it.

@veler veler merged commit 9a88b60 into main Jun 17, 2024
2 of 3 checks passed
@veler veler deleted the fix-windows10-theme branch June 17, 2024 15:31
@Brent-Sanchez
Copy link

Brent-Sanchez commented Jun 19, 2024

!!!!
I thought it was just me!
microsoft/PowerToys#33385
+==================================================+
The screenshots below are to show my current "accent" color (Morocco Sand colored title bar, explorer window)
It doesn't match the previous accent color that remained in PowerToys (369% saturation highlighter blue) This is without a restart.
image
image
+-----------------------------------------------------+
I might just be a dumb n00b, but my suspicion is that PowerToys and DevToys aren't playing nice together. One or the other tends to crash if both are active on the screen. So as I screwed around this more, I crashed PowerToys, and you might be able to predict what I'm going to say next.
The issue stopped. Since I didn't crash it on purpose, it took until until I started PowerToys back up to realize this for blidingly obvoius reasons. *DevToys resumed it's behavior from the officially released build, without any accented title bar.
I hope this helps you out! 🐱‍👓

@veler
Copy link
Collaborator Author

veler commented Jun 19, 2024

Hi,
Did you update do devtoys 2.0.2.0? The issue must be fixed in this version now.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows color accent fully changes the UI theme
3 participants