Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconcistency and bug in IUIMultilineTextInput #1102

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Mar 26, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

  1. The method to create IUIMultiLineTextInput is inconsistent with IUISingleLineTextInput.
  2. The UIHoverTooltip is inconsistent with UIHighlightedTextSpan, which they do similar things (add decoration to text)
  3. There is a bug: when setting Highlights, it removed Tooltip and vice versa.

What is the new behavior?

  1. Made the API more consistent (This causes a breaking change. Will need to update NuGet package and DevToys.Tools)
  2. Fixed the bug in MultiLineTextInputPresenter

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler requested a review from btiteux March 26, 2024 04:05
@veler veler merged commit 18912b8 into main Mar 30, 2024
@veler veler deleted the fix-iuimultilinetextinput-consistency-and-bug branch March 30, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants