Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of Open In New Window #1053

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Added support of Open In New Window #1053

merged 4 commits into from
Feb 17, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Feb 13, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 isn't able to open a tool in a new window yet.

What is the new behavior?

Added this feature back to Windows, but also MacOS and Linux.

I also added support for a context menu in the NavBar. The context menu items are created when the user do a right click on an item. Doing this way allows to:

  1. Instantiate / Allocate the context menu items only when the user does a right click on an item in the Nav Bar
  2. Change the context menu based on the type of item on which user does a right click (a group item? a tool?).

Other information

image

linux.mp4
macos.mov
windows.mp4

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Feb 13, 2024
@veler veler requested a review from btiteux February 13, 2024 16:21
@veler veler changed the title Dev/2.0 open new window Added support of Open In New Window Feb 14, 2024
@veler veler merged commit 7c6ce17 into dev/2.0 Feb 17, 2024
@veler veler deleted the dev/2.0-open-new-window branch February 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants