Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed missing parts of IFileStorage in DevToys CLI #1048

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Feb 9, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

IFileStorage in DevToys.CLI was missing some functionalities.

What is the new behavior?

Completed missing parts of IFileStroage in DevToys CLI

Other information

Performed some manual tests.

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Feb 9, 2024
@veler veler requested a review from btiteux February 9, 2024 06:58
@veler veler changed the title Completed missing parts of IFileStroage in DevToys CLI Completed missing parts of IFileStorage in DevToys CLI Feb 10, 2024
@veler veler merged commit eceb754 into dev/2.0 Feb 17, 2024
@veler veler deleted the dev/2.0-cli-filestorage branch February 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants