Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on Linux on startup #1046

Merged
merged 6 commits into from
Feb 11, 2024
Merged

Fix crash on Linux on startup #1046

merged 6 commits into from
Feb 11, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Feb 9, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

In GTK 4.10 on Ubuntu, using either GTKSharp or Gir.Core NuGet package, we're unable to invoke gtk_file_dialog_new to create a new file dialog. Why? I have no clue.

What is the new behavior?

Workaround this issue by using GTK's FileChooserNative API.

Other information

This PR also includes a small refactoring and more bug fixes:

  • ThemeListener is now able to properly switch between the light and dark theme.
  • Fixed a bug where we were trying to navigate to wwwroot/index.html from the wrong root directory. I think in the future we should consider using an embedded resource instead, if possible.
  • Tiny refactoring in DevToys MacOS's BlazorWebView.

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Feb 9, 2024
@veler veler requested a review from btiteux February 9, 2024 00:42
@veler veler merged commit a9a959f into dev/2.0 Feb 11, 2024
@veler veler deleted the dev/2.0-fix-linux branch February 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants