-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on Linux on startup #1046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veler
commented
Feb 9, 2024
src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs
Show resolved
Hide resolved
veler
commented
Feb 9, 2024
src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs
Show resolved
Hide resolved
veler
commented
Feb 9, 2024
veler
commented
Feb 9, 2024
veler
commented
Feb 9, 2024
veler
commented
Feb 9, 2024
src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs
Show resolved
Hide resolved
btiteux
approved these changes
Feb 11, 2024
…g `dotnet publish`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
In GTK 4.10 on Ubuntu, using either GTKSharp or Gir.Core NuGet package, we're unable to invoke gtk_file_dialog_new to create a new file dialog. Why? I have no clue.
What is the new behavior?
Workaround this issue by using GTK's FileChooserNative API.
Other information
This PR also includes a small refactoring and more bug fixes:
wwwroot/index.html
from the wrong root directory. I think in the future we should consider using an embedded resource instead, if possible.Quality check
Before creating this PR: