Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported XML Validator to DevToys 2.0 #1011

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Ported XML Validator to DevToys 2.0 #1011

merged 3 commits into from
Jan 3, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 23, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys 2.0 doesn't have a XML Validator yet.

What is the new behavior?

Ported XML Validator from DevToys 1.0 to 2.0 along with its unit tests. I refactored its code too.

Other information

image

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@veler veler added the devtoys-v2.0 DevToys v2.0 label Dec 23, 2023
@veler veler requested a review from btiteux December 23, 2023 06:39
@veler veler merged commit 76b6203 into dev/2.0 Jan 3, 2024
@veler veler deleted the dev/2.0-xml-validator branch January 3, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtoys-v2.0 DevToys v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After copying "cjsj" to open the software, it will automatically exit within a few seconds
3 participants