Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO 8601 Support In Date Converter #48

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

yui10
Copy link
Contributor

@yui10 yui10 commented Jul 3, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: DevToys-app/DevToys#1229

What is the new behavior?

image

  • Conversion by ISO 8601 is now possible

Other information

Any format that can be converted with DateTimeOffset.TryParse is available.
https://learn.microsoft.com/en-us/dotnet/api/system.datetimeoffset.tryparse?view=net-8.0

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I will try to review it ASAP

@veler
Copy link
Collaborator

veler commented Jul 17, 2024

Hello,
Sorry for the time it took me to look into it. It looks good to me. Thanks for your contribution!

@veler veler merged commit 680cba8 into DevToys-app:main Jul 17, 2024
3 checks passed
@yui10 yui10 deleted the DateConverter branch July 17, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants