Fixed "${TEST_INDEX} is initialized to 'null' for video recording path pattern" (close #3455) #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 8171385 have failed. See details: |
VasilyStrelyaev
requested review from
VasilyStrelyaev,
AndreyBelym and
AlexKamaev
AndreyBelym
approved these changes
Feb 25, 2019
|
❌ Tests for the commit 1f55b48 have failed. See details: |
AlexKamaev
approved these changes
Feb 25, 2019
|
✅ Tests for the commit 1f55b48 have passed. See details: |
VasilyStrelyaev
requested changes
Feb 25, 2019
src/notifications/warning-message.js
Outdated
|
|
||
| problematicPathPatternPlaceholderForVideoRecording: '{placeholderList} path pattern placeholder{suffix} {verb} not suitable for the video recording\'s "pathPattern" option.\n' + | ||
| '\n' + | ||
| '{pronoun} value{suffix} will be replaced with an empty string.' |
There was a problem hiding this comment.
Dirk's version:
problematicPathPatternPlaceholderForVideoRecording: 'The {placeholderList} path pattern placeholder{suffix} cannot be applied to the recorded video.\n' +
'\n' +
'The placeholder{suffix} {verb} replaced with an empty string.'where {suffix} is s and {verb} is either was or were.
|
❌ Tests for the commit 53fd567 have failed. See details: |
|
It was the Past tense - |
|
❌ Tests for the commit fb412ab have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit fb412ab have failed. See details: |
|
✅ Tests for the commit fb412ab have passed. See details: |
|
@VasilyStrelyaev FPR |
VasilyStrelyaev
approved these changes
Feb 26, 2019
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…h pattern" (close DevExpress#3455) (DevExpress#3481) * initial commit * functional test * unit tests * updated the test name * fix test * fix test * Update warning-message.js * Update warning template * fixed the message and restructured the string utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreyBelym @AlexKamaev @VasilyStrelyaev