Use a location port for service urls #2308
Conversation
| @@ -2,14 +2,16 @@ | |||
| if (window !== window.top) | |||
| return; | |||
|
|
|||
| var origin = location.protocol + '//' + location.host; | |||
There was a problem hiding this comment.
Just use the location.origin property.
src/browser/connection/index.js
Outdated
| @@ -53,6 +53,10 @@ export default class BrowserConnection extends EventEmitter { | |||
| this.statusDoneUrl = `${gateway.domain}/browser/status-done/${this.id}`; | |||
| this.initScriptUrl = `${gateway.domain}/browser/init-script/${this.id}`; | |||
|
|
|||
| this.heartbeatRelativeUrl = `/browser/heartbeat/${this.id}`; | |||
There was a problem hiding this comment.
this.heartbeatUrl = `${gateway.domain}${this.heartbeatRelativeUrl}`;
...
|
❌ Tests for the commit 5f5be31 have failed. See details: |
|
❌ Tests for the commit 2bdfc4f have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit 2bdfc4f have passed. See details: |
|
❌ Tests for the commit 20ee77f have failed. See details: |
| }); | ||
|
|
||
| test('Second test', async () => { | ||
| }); |
There was a problem hiding this comment.
Let's add a comment and describe why do we need the second test
|
✅ Tests for the commit 6b14992 have passed. See details: |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 13eb13e have failed. See details: |
|
✅ Tests for the commit 13eb13e have passed. See details: |
* Use a location port for service urls * fix review issues * add test * fix lint * add comment
No description provided.