Fix typo in TS defs (closes #1541) #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 84f62c3 have failed. See details: |
AndreyBelym
force-pushed
the
gh-1541
branch
3 times, most recently
from
b57750c
to
60af4e2
Compare
AlexanderMoskovkin
suggested changes
Jun 19, 2017
| @@ -71,8 +71,20 @@ function openRemoteBrowsers () { | |||
| }; | |||
|
|
|||
| var openBrowserPromises = browsersInfo.map(function (browserInfo) { | |||
| return connector.startBrowser(browserInfo.settings, browserInfo.connection.url, buildInfo, | |||
| isBrowserStack ? { openingTimeout: BROWSER_OPENING_TIMEOUT } : null); | |||
| if (!isBrowserStack || browserInfo.settings.alias !== 'chrome-osx') { | |||
There was a problem hiding this comment.
Please add a note that it's a temporary workaround to fix a problem on BrowserStack when a new page in a new tab is opened during testing unexpectedly
|
❌ Tests for the commit 60af4e2 have failed. See details: |
|
❌ Tests for the commit c0c2d78 have failed. See details: |
|
❌ Tests for the commit 0b7299d have failed. See details: |
|
❌ Tests for the commit d7ecefc have failed. See details: |
|
✅ Tests for the commit d7ecefc have passed. See details: |
AlexanderMoskovkin
approved these changes
Jun 19, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
* Fix typo in TS defs (closes DevExpress#1541) * Update comment about a BrowserStack issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @AlexanderMoskovkin