Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override WebSocket class #911

Closed
LavrovArtem opened this issue Nov 8, 2016 · 4 comments
Closed

Override WebSocket class #911

LavrovArtem opened this issue Nov 8, 2016 · 4 comments
Labels
AREA: client STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug TYPE: enhancement
Milestone

Comments

@LavrovArtem
Copy link
Contributor

LavrovArtem commented Nov 8, 2016

Request for socket opening sends the 'cookie' header with document.cookie value, but we don't write cookie in document.cookie, we save cookie in hammehread's settings.

https://testcafe-discuss.devexpress.com/t/set-cookies-on-client-side/65/6

@johnwebbcole
Copy link

This one is biting me as well... our session id is in in the cookie and we need that to authenticate the web socket request. Any timeframe on fixing this? I'm running testcafe 0.17.2.

@miherlosev
Copy link
Contributor

I cannot provide an exact timeframe for this task.
But, we've planned to do this in the current development sprint (it ends in 2 weeks).
If we don't have time then the task will be moved to the next sprint.

@drgnorq
Copy link

drgnorq commented Oct 4, 2017

Same issue here. We need to be able to extract the cookie header form websocket connection request, so we can authenticate the websocket request. In 0.17.2 (and also the 0.18 alpha version) the request.cookie header is missing. Hopefully the patch will be available soon. Let me know if we can help testing new versions. Hopefully this new version will also take into account the cookie flags (http only and/or secure). It would be very nice if we could modify the flags of cookies maintained by hammerhead from our test script.

@AlexanderMoskovkin AlexanderMoskovkin changed the title We should override the WebSocket class Override WebSocket class Oct 9, 2017
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Oct 10, 2017
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Oct 10, 2017
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Nov 1, 2017
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Nov 3, 2017
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
* fix `Override WebSocket class` (close DevExpress#911)

* fix origin header

* add server tests

* fix tests

* fix review's issues

* fix tests

* fix tests

* fix review issue

* add tests and override origin property

* add server tests

* add one more client test
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AREA: client STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug TYPE: enhancement
Projects
None yet
Development

No branches or pull requests

4 participants