Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove integrity attributes from resources #235

Closed
inikulin opened this issue Nov 2, 2015 · 3 comments
Closed

Remove integrity attributes from resources #235

inikulin opened this issue Nov 2, 2015 · 3 comments
Assignees
@LavrovArtem @Farfurix
Labels
AREA: client AREA: server !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot SYSTEM: resource processing TYPE: bug
Milestone
Sprint #11

Comments

@inikulin
Copy link
Contributor

inikulin commented Nov 2, 2015

See: http://www.w3.org/TR/SRI/

This attribute is used to avoid MITM attacks. Attribute contains SHA of the desired resource. Which doesn't work for us. This is widely used currently. And it brokes e.g. GitHub proxying. I suggest to remove this attribute entirely. It applies only to <script> and <link> elements.
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
Remove 'integrity' attributes from resources (close DevExpress#235)
797c96f
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
Remove 'integrity' attributes from resources (close DevExpress#235)
6841b48
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
Remove 'integrity' attributes from resources (close DevExpress#235)
a3db6ee
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
@LavrovArtem
Remove 'integrity' attributes from resources (close DevExpress#235)
1597fd8
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
@LavrovArtem
Remove 'integrity' attributes from resources (close DevExpress#235)
2315c51
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
Remove attributes from resources (close DevExpress#235)
5969715
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
Remove attributes from resources (close DevExpress#235)
a1f4786
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
Remove attributes from resources (close DevExpress#235)
35162d6
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
@LavrovArtem
Remove attributes from resources (close DevExpress#235)
1e173cc
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 2, 2015
@LavrovArtem
Remove attributes from resources (close DevExpress#235)
20cbc44
churkin pushed a commit to churkin/testcafe-hammerhead that referenced this issue Nov 3, 2015
@LavrovArtem
Remove attributes from resources (close DevExpress#235)
f96e434
LavrovArtem added a commit that referenced this issue Nov 3, 2015
@LavrovArtem
Merge pull request #236 from churkin/master
89a5f35 
Remove  'integrity' attributes from resources (close #235)
@LavrovArtem
Copy link
Contributor

Unprocessed cases:

script.setAttribute('integrity', '...');
script.integrity = '...';

@LavrovArtem LavrovArtem reopened this Apr 18, 2018
@LavrovArtem LavrovArtem added this to the Sprint #11 milestone Apr 18, 2018
@LavrovArtem LavrovArtem self-assigned this Apr 18, 2018
@Farfurix Farfurix self-assigned this Apr 25, 2018
@Farfurix
Copy link
Contributor

I'm working on it.

@Farfurix Farfurix mentioned this issue Apr 27, 2018
Merged
@miherlosev miherlosev mentioned this issue May 7, 2018
Closed
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@LavrovArtem @AndreyBelym
Remove attributes from resources (close DevExpress#235)
b4d7afe
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@Farfurix @AndreyBelym
fix Remove integrity attributes from resources (close DevExpress#235
d2b1e03 
) (DevExpress#1592)

* fix `Remove `integrity` attributes from resources`

* add semicolon

* fix Edge and IE11 cases

* fix dom-processor-test

* requested changes

* fix comments

* requested changes

* requested changes

* requested changes

* set edge version for client tests

* requested changes: rename hasCorrectIntegrityAttr to hasIntegrityAttr in attribute-test
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LavrovArtem LavrovArtem

@Farfurix Farfurix

Labels
AREA: client AREA: server !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot SYSTEM: resource processing TYPE: bug
Projects
None yet
Milestone
Sprint #11
Development

No branches or pull requests
3 participants
@inikulin @LavrovArtem @Farfurix