Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mootools errors from testcafe seem to cause a button to not function after clicking it #1824

Closed
barretvasilchik opened this issue Aug 29, 2018 · 6 comments
Assignees
Labels
AREA: client STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone

Comments

@barretvasilchik
Copy link

Are you requesting a feature or reporting a bug?

Bug

What is the current behavior?

I am unable to click a button, even if I pause the test and manually click the button. The test doesn't say the button can't be clicked but I can't progress in the application b/c clicking the button doesn't actually do anything. There are various mootools errors popping up in the console log that do not happen when you access the page without testcafe

This button gets clicked but doesn't actually function how it's supposed to. It would normally bring up a dialogue modal asking if you're sure you want to finish the practice test.

What is the expected behavior?

The button should be able to be clickable and execute Its purpose and there shouldn't be any errors in the console log about mootools.

How would you reproduce the current behavior (if this is a bug)?

Execute the test I have provided and try clicking the finish practice button at the end and notice that it will not do anything

Provide the test code and the tested page URL (if applicable)

Tested page URL:

Note this url can't be directly accessed you would have to run the test or manually do what the test is doing to get here

https://placeu.net/placementtest/take/1300/practice/5b85be7390b313f018ecf88e/1

Test code (I included a debug at the end so you can manually try to click and inspect the errors)

import { Selector }      from 'testcafe';

fixture `testcafe canvas`
    .page `https://webassign.instructure.com/login/canvas`;

const medwait            = 5000
const longwait           = 15000;
const course             = Selector('.ic-DashboardCard__header-title');
const ltiLink            = Selector('.item_link');
const loadBtn            = Selector('.btn[type="submit"]');
const startPracticeBtn   = Selector('button[wa-qa="placement-practice-button"]')
const confirmPracticeBtn = Selector('start-practice-confirmation button.wa-button-primary');
const finishPracticeBtn  = Selector('wa-button[on-click="$ctrl.finishPractice()"] button.wa-submit-test-btn');
const spinner            = Selector('.md-spinner-wrapper');

test('Instructor', async t => {
    await t
        .typeText(Selector('#pseudonym_session_unique_id'), '[email protected]')
        .typeText(Selector('#pseudonym_session_password'), 'Password1')
        .click(Selector('#login_form .Button--login'))
        .expect(course.exists).ok({timeout: medwait})
        .click(course)
        .expect(ltiLink.exists).ok({timeout: medwait})
        .click(ltiLink)
        .expect(loadBtn.exists).ok({timeout: medwait})
        .click(loadBtn)
        .expect(startPracticeBtn.exists).ok({timeout: medwait})
        .click(startPracticeBtn)
        .expect(confirmPracticeBtn.exists).ok({timeout: medwait})
        .click(confirmPracticeBtn)
        .expect(spinner.exists).notOk({ timeout: longwait })
        .expect(finishPracticeBtn.exists).ok({timeout: medwait})
        .click(finishPracticeBtn).debug();
});

Specify your

  • operating system: Mac Osx Sierra
  • testcafe version: 0.21.1
  • node.js version: 8.2.1
@miherlosev
Copy link
Contributor

Hi @barretvasilchik

I've reproduced the problem. We will fix it during the next development sprint.

@Farfurix
Copy link
Contributor

Farfurix commented Sep 4, 2018

I'm working on it.

@AndreyBelym AndreyBelym transferred this issue from DevExpress/testcafe Nov 12, 2018
@miherlosev miherlosev added this to the Sprint #21 milestone Nov 12, 2018
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Nov 14, 2018
@LavrovArtem LavrovArtem modified the milestones: Sprint #21, Sprint #22 Nov 19, 2018
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Nov 20, 2018
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Nov 20, 2018
@LavrovArtem
Copy link
Contributor

@barretvasilchik
The fix was published in [email protected].

@bvasilchik
Copy link

Thank you very much. Im on holiday right now but should be able to test it out on Monday

@barretvasilchik
Copy link
Author

sorry for the late follow up. I am thrilled to report that the fix worked on my end. Thank you so much for fixing this. This will enable my team to move forward

AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
…hout src (fix DevExpress#1824) (DevExpress#1836)

* overridden functions should have the right prototype in an iframe without src (fix DevExpress#1824)

* try to fix ie tests (close DevExpress#1584)

* fix tests

* fix tests

* fix functional test

* refactoring

* fix unstable test

* remove comment
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AREA: client STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Development

No branches or pull requests

6 participants