-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support electron v8 #64
Comments
Hello, Thank you for reaching us. We will examine the possibility of adding the latest Electron version. |
The issue seems to be related to this code: testcafe-browser-provider-electron/src/ipc.js Lines 199 to 201 in f4d0074
When called from here:
At the point |
Thank you for the research. This information was very helpful for us. |
It's still failing. It seems more an issue of `testcafe-browser-provider` DevExpress/testcafe-browser-provider-electron#64
@LavrovArtem May I ask you if there any updates to support Electron 8.x ? |
We have not established any exact dates yet. Any personal estimate may be misleading, so I cannot currently tell you the precise date. |
@veado created a PR, you can check it with my fork if you clone it and build with gulp then |
@steveetm Thank you for your PR, we'll review it soon. |
Hello, does this work with electron v9? |
In my testing @lukechu10 it does work sometimes, but sometimes it leaves the window open indefinitely at the end of the test run which makes it impossible to use on a CI environment. p.s. if you want a version of this that works with Electron 8.x you can use http://npmjs.com/@ln-zap/testcafe-browser-provider-electron which I created that includes the fix from #65 which has been merged here but not yet included in a new release. |
@lukechu10 Currently, we don't have news about Electron v9 support. |
I see that @steveetm's PR was merged back in May. Any plans to cut a release with that change? I also see that @mrfelton made a fork with the fix, but I'm a bit of a Node noob, and I guess I don't know how to include it. I tried
to
and running
I got the same results against Electron v8.1.1 (the version I was already using), 8.2.3 (the version specified by package.json in #65), and 8.3.4 (latest 8.x). Am I doing something wrong? Are there troubleshooting steps I can take? I'm currently scouring testcafe's source code, trying to learn how it discovers browser provider plugins. |
I've now determined that the problem is the forked module name, combined with TestCafe's rigorous naming scheme for browser-provider plugins. To load the plugin, TestCafe (browser/provider/pool.js::_getProviderModule) takes the passed-in module name I need it to call |
Hello, I published a new version: v0.0.15. In the case of any custom fork, you can use a specific scope of the installed electron provider module. "dependencies": {
"@ln-zap/testcafe-browser-provider-electron": "0.0.15-alpha.3", Command:
Test imports: import { setElectronDialogHandler } from '@ln-zap/testcafe-browser-provider-electron'; Or, you can simply install the
In this case, you don't need to use any scope in your commands and imports. |
Any news on when the 0.0.15 release will be done? |
Hello, I fixed the GitHub Electron provider version. Anyway, you can install the |
I have my app with |
Hello, Yes. Since we merged these changes, we can close it. If anyone encounters issues with Electron 8, please feel free to open a new bug report. |
Doesn't seem to work with electron v8. It's not able to properly start the app.
Here is the full output of the test run. Note this same setup works under electron v7.
The text was updated successfully, but these errors were encountered: