feat(react-grid): cancel sorting by using the Ctrl key #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
reviewed
May 17, 2017
| @@ -18,7 +18,7 @@ export const GroupPanelCell = ({ | |||
| <span | |||
| onClick={(e) => { | |||
| if (!allowSorting) return; | |||
| changeSortingDirection({ keepOther: e.shiftKey }); | |||
| changeSortingDirection({ keepOther: e.shiftKey || e.ctrlKey, remove: e.ctrlKey }); | |||
There was a problem hiding this comment.
Ctrl + Click is used in Windows and Linux. On macOS, the following keyboard shortcut is used: CMD + Click
kvet
approved these changes
May 17, 2017
dxbykov
approved these changes
May 17, 2017
viterobk
reviewed
May 23, 2017
viterobk
approved these changes
May 24, 2017
viterobk
requested review from
ElyaC,
annnke,
AnnaTikh,
AnnaZelenova,
YanaOrlova and
dirk-pieterse
dirk-pieterse
approved these changes
May 24, 2017
|
@SergeyAlexeev can you give some example with cancel sorting on some column? |
|
@SergeyAlexeev sorry my fail, bad described. I mean to disable sort on column(user cann`t click on this column header). For example i have 'ID','Name'... i want to have possibility sort by 'Name', but disabled sort by 'ID' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.