-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-grid): rename the *hiddenColumns getters and props #651
Changes from 4 commits
e1a850b
59502f0
161120b
2276956
4b991f2
2474115
1e279fb
569abba
d24b9b4
ca00f1d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
export const columnChooserItems = (columns, hiddenColumns) => | ||
columns.map(column => ({ column, hidden: hiddenColumns.indexOf(column.name) !== -1 })); | ||
export const columnChooserItems = (columns, hiddenColumnNames) => | ||
columns.map(column => ({ column, hidden: hiddenColumnNames.indexOf(column.name) !== -1 })); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
export const toggleColumn = (hiddenColumns, columnName) => ( | ||
hiddenColumns.indexOf(columnName) === -1 | ||
? [...hiddenColumns, columnName] | ||
: hiddenColumns.filter(hiddenColumn => hiddenColumn !== columnName) | ||
export const toggleColumn = (hiddenColumnNames, columnName) => ( | ||
hiddenColumnNames.indexOf(columnName) === -1 | ||
? [...hiddenColumnNames, columnName] | ||
: hiddenColumnNames.filter(hiddenColumn => hiddenColumn !== columnName) | ||
); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import { TABLE_DATA_TYPE } from './../table/constants'; | ||
|
||
export const visibleTableColumns = (tableColumns, hiddenColumns) => | ||
export const visibleTableColumns = (tableColumns, hiddenColumnNames) => | ||
tableColumns.filter(tableColumn => | ||
tableColumn.type !== TABLE_DATA_TYPE || hiddenColumns.indexOf(tableColumn.column.name) === -1); | ||
tableColumn.type !== TABLE_DATA_TYPE || | ||
hiddenColumnNames.indexOf(tableColumn.column.name) === -1); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,17 +29,17 @@ export default class Demo extends React.PureComponent { | |
{ columnName: 'sex', width: 100 }, | ||
], | ||
rows: generateRows({ length: 6 }), | ||
hiddenColumns: ['sex', 'car'], | ||
hiddenColumnNames: ['sex', 'car'], | ||
}; | ||
|
||
this.hiddenColumnsChange = (hiddenColumns) => { | ||
this.setState({ hiddenColumns }); | ||
this.hiddenColumnsChange = (hiddenColumnNames) => { | ||
this.setState({ hiddenColumnNames }); | ||
}; | ||
} | ||
|
||
render() { | ||
const { | ||
columns, rows, hiddenColumns, tableColumnExtensions, | ||
columns, rows, hiddenColumnNames, tableColumnExtensions, | ||
} = this.state; | ||
return ( | ||
<MUIGrid container> | ||
|
@@ -54,7 +54,7 @@ export default class Demo extends React.PureComponent { | |
/> | ||
<TableHeaderRow /> | ||
<TableColumnVisibility | ||
hiddenColumns={hiddenColumns} | ||
hiddenColumnNames={hiddenColumnNames} | ||
/> | ||
</Grid> | ||
</Paper> | ||
|
@@ -68,7 +68,7 @@ export default class Demo extends React.PureComponent { | |
</Toolbar> | ||
<ColumnChooser | ||
columns={columns} | ||
hiddenColumns={hiddenColumns} | ||
hiddenColumnNames={hiddenColumnNames} | ||
onHiddenColumnsChange={this.hiddenColumnsChange} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we also rename onHiddenColumnsChange to onHiddenColumnNamesChange? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems too long There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's leave it as is. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we introduce this complexity in naming guidelines? There is a simple rule. The onXXXChange spelling for an event and defaultXXX for a starting value. |
||
/> | ||
</Paper> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,12 +14,12 @@ Import the plugins listed above to enable a user to hide or show columns at runt | |
|
||
### Uncontrolled Mode | ||
|
||
In [uncontrolled mode](controlled-and-uncontrolled-modes.md#uncontrolled-mode), specify initially hidden columns via the `TableColumnVisibility` plugin's `defaultHiddenColumns` property. | ||
In [uncontrolled mode](controlled-and-uncontrolled-modes.md#uncontrolled-mode), specify initially hidden columns via the `TableColumnVisibility` plugin's `defaultHiddenColumnNames` property. | ||
|
||
.embedded-demo(column-chooser/uncontrolled) | ||
|
||
### Controlled Mode | ||
|
||
In [controlled mode](controlled-and-uncontrolled-modes.md#controlled-mode), pass the hidden columns to the `TableColumnVisibility` plugin's `hiddenColumns` property and handle the `onHiddenColumnsChange` event to control column visibility externally. | ||
In [controlled mode](controlled-and-uncontrolled-modes.md#controlled-mode), pass the hidden columns to the `TableColumnVisibility` plugin's `hiddenColumnNames` property and handle the `onHiddenColumnsChange` event to control column visibility externally. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ... pass the hidden column names to the ... |
||
|
||
.embedded-demo(column-chooser/controlled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is not in the plugins directory?