-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-grid): replace render functions with components in TableSelection #502
Conversation
|
||
### <a name="select-cell-args"></a>SelectCellArgs | ||
### TableSelectCellProps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, what about the Table
prefix?
showSelectAll | boolean | true | If true, the 'select all' checkbox is rendered in the header row. | ||
showSelectionColumn | boolean | true | If true, the selection column (that displays a selection checkboxes) is rendered. | ||
cellComponent | ElementType<[TableSelectCellProps](#tableselectcellprops)> | | A component that renders a selection cell (a cell containing a selection checkbox). | ||
headerCellComponent | ElementType<[TableSelectHeaderellProps](#tableselectcellprops)> | | A component that renders a cell containing the 'Select All' checkbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this anchor #tableselectcellprops
is wrong. Should be #tableselectheadercellprops
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TableSelectHeaderellProps -> TableSelectHeaderCellProps
…ctive into tableselection-components
BREAKING CHANGES:
The TableSelection plugin's
highlightSelected
property has been renamed tohighlightRow
. TheselectCellTemplate
andselectAllCellTemplate
properties have been replaced withcellComponent
, andheaderCellComponent
ones, which accept components instead of render functions. Find more details here: #496Properties passed to
headerCellComponent
have the same names as arguments passed to theselectAllCellTemplate
function with the following exceptions:onToggle
property is used instead of thetoggleAll
argument.disabled
property is used instead of theselectionAvailable
argument and it's value is inverted.Properties passed to
cellComponent
have the same names as arguments passed to theselectCellTemplate
function except for theonToggle
property, which is used instead of thechangeSelected
argument.