chore: use react-popper 2.x in bootstrap4 packages (permits React 18 support) #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glsignal
changed the title
VasilyStrelyaev
force-pushed
the
popper-2.x
branch
from
1b183d6
to
3afb236
Compare
Krijovnick
approved these changes
May 15, 2023
ivanblinov2k17
approved these changes
May 15, 2023
|
@glsignal, thank you for your contribution! I have added several commits to this pull request and now I'm merging it. The changes introduced in this PR will be released with the next minor update. |
|
Thank you for taking the time (and extra changes) to integrate this! It's a big help 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
With React 18 having been available for some time now, one thing holding back an upgrade is the version of Popper in use in the bootstrap4 packages here (since popper 1.x only declares compatibility with up to React 17).
Since Popper 2.x is both compatible with React 18 and still exposes the render-props for compatibility with the existing class-based components in here, is it possible / reasonable to update the package to the 2.x line?