-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-core): implement dependencies support for PluginContainer #237
feat(react-core): implement dependencies support for PluginContainer #237
Conversation
packages/dx-core/src/utils.js
Outdated
return aPosition.length - bPosition.length; | ||
}; | ||
|
||
export const insertWithSorting = (newItem, array) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly strange API. Typically we specify the array to work with in the first parameter. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking in the way "insert something somewhere". But I can change this in order to stay consistent with other methods.
No description provided.