fix(react-grid): Put the dx-react-grid dependencies in order #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viterobk
approved these changes
Jun 16, 2017
viterobk
requested review from
ElyaC,
annnke,
AnnaTikh,
AnnaZelenova,
YanaOrlova and
dirk-pieterse
dxbykov
changed the title
kvet
approved these changes
Jun 19, 2017
packages/dx-react-grid/README.md
Outdated
| @@ -12,21 +12,27 @@ The DevExtreme React Grid component allows you to display table data with a set | |||
| npm i @devexpress/dx-react-grid --save | |||
| ``` | |||
|
|
|||
| This package does not contain any visual components, so all examples provided below use the DevExtreme React Grid Bootstrap3 package to use Bootstrap rendering for the Grid visual components. | |||
| This package does not contain any visual components; all examples below use the DevExtreme React Grid Bootstrap3 package to use Bootstrap rendering for the Grid visual components. | |||
There was a problem hiding this comment.
"all examples below use the DevExtreme React Grid Bootstrap3 package to use Bootstrap rendering for the Grid visual components" is a confusing sentence. Consider rewriting it.
There was a problem hiding this comment.
We can omit the second part of the sentence since it's obvious that if we use the BS3 package then BS3 will be used for rendering the Grid.
There was a problem hiding this comment.
all examples below import modules from the DevExtreme React Grid Bootstrap 3 package to use Bootstrap rendering for the Grid visual components
dirk-pieterse
approved these changes
Jun 19, 2017
viterobk
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.