chore(react-chart): refactor series #1279
Conversation
|
Add subheader 'react-chart' to the PR title, please |
|
The 'point-customization' demo does not display promised feature: |
alexey-semikozov
changed the title
| valueField="ru" | ||
| argumentField="year" | ||
| /> | ||
| <AreaSeries | ||
| color="black" |
There was a problem hiding this comment.
Do we want to see this colors in this demo?
| }) => ({ | ||
| d: arc() | ||
| .innerRadius(0) | ||
| .outerRadius(radius) |
There was a problem hiding this comment.
Why the 'innerRadius' and 'outerRadius' options do not apply?
| const dPoint = symbol().size([size ** 2]).type(symbolCircle)(); | ||
| const offSet = scales.xScale.bandwidth ? scales.xScale.bandwidth() / 2 : 0; | ||
| export const pointAttributes = () => { | ||
| const dPoint = symbol().size([DEFAULT_POINT_SIZE ** 2]).type(symbolCircle)(); |
There was a problem hiding this comment.
In the doc of the series the 'point.size' option remains. And it looks like BC, that should be described.
| @@ -9,137 +9,146 @@ import { | |||
| } from 'd3-shape'; | |||
| import { createScale } from '../../utils/scale'; | |||
|
|
|||
| const getX = ({ x }) => x; | |||
| const getX = ({ x, width }) => x + (width / 2); | |||
There was a problem hiding this comment.
For that new code no tests
| export const findSeriesByName = (name, series) => series.find( | ||
| seriesItem => seriesItem.uniqueName === name, | ||
| ); | ||
| export const barCoordinates = ( |
There was a problem hiding this comment.
There are no tests on this method. It is the same with the dArea, dLine, dBar and dSpline methods.
| @@ -5,12 +5,11 @@ import classNames from 'classnames'; | |||
| export class Area extends React.PureComponent { | |||
| render() { | |||
| const { | |||
| x, y, className, pointComponent, pointStyle, coordinates, path, themeColor, ...restProps | |||
| className, pointComponent, pointStyle, coordinates, path, color, ...restProps | |||
There was a problem hiding this comment.
The 'pointComponent' property is not needed in the area, line, spline series
| const { coordinates } = props; | ||
| return ( | ||
| <React.Fragment> | ||
| <LineSeries.Path {...props} coordinates={coordinates.slice(0)} /> |
There was a problem hiding this comment.
Looks like there are extra actions with the coordinates property.
| @@ -8,7 +8,6 @@ export class AreaSeries extends React.PureComponent { | |||
| return ( | |||
| <AreaSeriesBase | |||
| seriesComponent={Area} | |||
| pointComponent={() => null} | |||
| {...this.props} | |||
| /> | |||
There was a problem hiding this comment.
The string AreaSeries.Point = Point is not expected there. The same in the material-ui theme in all line series (spline, line, area)
BREAKING CHANGES:
Previously, we had the
pointComponentproperty for drawing and customizingLineSeries,SplineSeries, andAreaSeriesplugin points. But since we have a scatter series, this property has become unnecessary. Use theScatterSeriesplugin or customize thepathComponentof the corresponding plugin.fixes #1271