Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-chart): add API to manage series in stacks #1227

Merged
merged 13 commits into from
Jul 12, 2018

Conversation

Krijovnick
Copy link
Contributor

@Krijovnick Krijovnick commented Jul 5, 2018

BREAKING CHANGES:

The 'SeriesFamily' plugin has been renamed to 'Stack' to make it meaning more transparent.

const stacks = getStacks(series);

const arrayOfStacks = Object.entries(stacks).reduce((prevValue, item) => ({
...prevValue,
[item[0]]: stack()
.keys(item[1].keys)
.order(stackOrderNone)
.offset(stackOffsetNone)(data),
.order(stackOrder || stackOrderNone)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move default values to arguments

@Krijovnick Krijovnick changed the title chore(react-chart): add seriesFamily API chore(react-chart): rename seriesFamily to stack and add API Jul 11, 2018
@Krijovnick Krijovnick changed the title chore(react-chart): rename seriesFamily to stack and add API feat(react-chart): rename seriesFamily to stack and add API Jul 11, 2018
@Krijovnick Krijovnick changed the title feat(react-chart): rename seriesFamily to stack and add API feat(react-chart): rename SeriesFamily plugin to Stack and add API Jul 11, 2018
@Krijovnick Krijovnick requested a review from kvet July 11, 2018 08:52
@Krijovnick Krijovnick changed the title feat(react-chart): rename SeriesFamily plugin to Stack and add API feat(react-chart): add API to manage series in stacks Jul 11, 2018
@Krijovnick Krijovnick merged commit 4239e7f into DevExpress:master Jul 12, 2018
@Krijovnick Krijovnick deleted the seriesFamily branch July 12, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants