[Typescript] The type definitions for properties in CustomGroupingProps interface are wrong

[franklixuefei]

• I have searched this repository's issues and believe that this is not a duplicate.

Current Behaviour

The types for grouping and expandedGroups in CustomGroupingProps do not accept null, which does not match with the implementation.

export interface CustomGroupingProps {
  /** A function that extracts groups from the specified data. It is executed recursively for the root and nested groups. */
  getChildGroups: (currentRows: Array<any>, grouping: Grouping, rootRows: Array<any>) => Array<{ key: number | string, value?: any, childRows?: Array<any> }>;
  /** Specifies columns by which data is grouped. */
  grouping?: Array<Grouping>;
  /** Specifies the expanded groups. */
  expandedGroups?: Array<GroupKey>;
}

Expected Behaviour

The types for grouping and expandedGroups in CustomGroupingProps should be able to accept null.

export interface CustomGroupingProps {
  /** A function that extracts groups from the specified data. It is executed recursively for the root and nested groups. */
  getChildGroups: (currentRows: Array<any>, grouping: Grouping, rootRows: Array<any>) => Array<{ key: number | string, value?: any, childRows?: Array<any> }>;
  /** Specifies columns by which data is grouped. */
  grouping?: Array<Grouping> | null;
  /** Specifies the expanded groups. */
  expandedGroups?: Array<GroupKey> | null;
}

Your Environment

devextreme-reactive: 1.2.0-beta1
react: 16.2.0
browser: Chrome/Edge
material-ui: yes

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests.