refactor(react-grid): rename the *hiddenColumns getters and props #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
reviewed
Jan 10, 2018
| @@ -1,2 +1,2 @@ | |||
| export const columnChooserItems = (columns, hiddenColumns) => | |||
| columns.map(column => ({ column, hidden: hiddenColumns.indexOf(column.name) !== -1 })); | |||
| export const columnChooserItems = (columns, hiddenColumnNames) => | |||
There was a problem hiding this comment.
Why this is not in the plugins directory?
| @@ -68,7 +68,7 @@ export default class Demo extends React.PureComponent { | |||
| </Toolbar> | |||
| <ColumnChooser | |||
| columns={columns} | |||
| hiddenColumns={hiddenColumns} | |||
| hiddenColumnNames={hiddenColumnNames} | |||
| onHiddenColumnsChange={this.hiddenColumnsChange} | |||
There was a problem hiding this comment.
Maybe we also rename onHiddenColumnsChange to onHiddenColumnNamesChange?
There was a problem hiding this comment.
It seems too long
There was a problem hiding this comment.
Why do we introduce this complexity in naming guidelines? There is a simple rule. The onXXXChange spelling for an event and defaultXXX for a starting value.
|
|
||
| .embedded-demo(column-chooser/uncontrolled) | ||
|
|
||
| ### Controlled Mode | ||
|
|
||
| In [controlled mode](controlled-and-uncontrolled-modes.md#controlled-mode), pass the hidden columns to the `TableColumnVisibility` plugin's `hiddenColumns` property and handle the `onHiddenColumnsChange` event to control column visibility externally. | ||
| In [controlled mode](controlled-and-uncontrolled-modes.md#controlled-mode), pass the hidden columns to the `TableColumnVisibility` plugin's `hiddenColumnNames` property and handle the `onHiddenColumnsChange` event to control column visibility externally. |
There was a problem hiding this comment.
... pass the hidden column names to the ... hiddenColumnNames property ?
…ctive into hiddenColumns-hiddenColumnNames
kvet
approved these changes
Jan 10, 2018
MaximKudriavtsev
approved these changes
Jan 10, 2018
…ctive into hiddenColumns-hiddenColumnNames
viterobk
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
We renamed the following TableColumnVisibility plugin's properties to improve the API consistency:
hiddenColumns->hiddenColumnNamesdefaultHiddenColumns->defaultHiddenColumnNamesonHiddenColumnsChange->onHiddenColumnNamesChangeThe
hiddenColumnsgetter has been renamed tohiddenColumnNames.