refactor(react-grid): replace render functions with components in TableSelection #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
changed the title
kvet
requested review from
SergeyAlexeev and
gsobolev
and removed request for
SergeyAlexeev
SergeyAlexeev
approved these changes
Nov 24, 2017
gsobolev
approved these changes
Nov 27, 2017
|
|
||
| ### <a name="select-cell-args"></a>SelectCellArgs | ||
| ### TableSelectCellProps |
There was a problem hiding this comment.
Again, what about the Table prefix?
viterobk
approved these changes
Nov 29, 2017
| showSelectAll | boolean | true | If true, the 'select all' checkbox is rendered in the header row. | ||
| showSelectionColumn | boolean | true | If true, the selection column (that displays a selection checkboxes) is rendered. | ||
| cellComponent | ElementType<[TableSelectCellProps](#tableselectcellprops)> | | A component that renders a selection cell (a cell containing a selection checkbox). | ||
| headerCellComponent | ElementType<[TableSelectHeaderellProps](#tableselectcellprops)> | | A component that renders a cell containing the 'Select All' checkbox. |
There was a problem hiding this comment.
It looks like this anchor #tableselectcellprops is wrong. Should be #tableselectheadercellprops.
There was a problem hiding this comment.
TableSelectHeaderellProps -> TableSelectHeaderCellProps
…ctive into tableselection-components
viterobk
approved these changes
Nov 29, 2017
dirk-pieterse
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
The TableSelection plugin's
highlightSelectedproperty has been renamed tohighlightRow. TheselectCellTemplateandselectAllCellTemplateproperties have been replaced withcellComponent, andheaderCellComponentones, which accept components instead of render functions. Find more details here: #496Properties passed to
headerCellComponenthave the same names as arguments passed to theselectAllCellTemplatefunction with the following exceptions:onToggleproperty is used instead of thetoggleAllargument.disabledproperty is used instead of theselectionAvailableargument and it's value is inverted.Properties passed to
cellComponenthave the same names as arguments passed to theselectCellTemplatefunction except for theonToggleproperty, which is used instead of thechangeSelectedargument.