Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Stop propagation on details button click. #492

Closed
dmtrKovalenko opened this issue Nov 17, 2017 · 1 comment · Fixed by #494
Closed

[Bug] Stop propagation on details button click. #492

dmtrKovalenko opened this issue Nov 17, 2017 · 1 comment · Fixed by #494
Assignees
@MaximKudriavtsev
Labels
bug Grid The DevExtreme Reactive Grid component

Comments

@dmtrKovalenko
Copy link

I have used such way pass an event on body row click, but lately, when you moved this button to material-ui IconButton it started to propagate event on click.
cropped-stop-event-bug

Expected Behavior

It should not dispatch event on the BodyRow

Steps to reproduce

  1. Create custom row template, and add onClick event to the TableRow
  2. Add detail plugin to the data grid
  3. Click on the expand detail view button
  4. Refer that onClick event was dispatched.

It should be easily fixed on adding e.stopPropagation to Icon button

Environment

Tech Version
Material-UI ^1.0.0-beta.21
React ^16.0.0
dx-react-core ^1.0.0-beta.1
dx-react-grid ^1.0.0-beta.1
dx-react-grid-material-ui ^1.0.0-beta.1
@kvet kvet added the bug label Nov 17, 2017
@MaximKudriavtsev MaximKudriavtsev self-assigned this Nov 20, 2017
@MaximKudriavtsev MaximKudriavtsev mentioned this issue Nov 20, 2017
Merged
MaximKudriavtsev added a commit that referenced this issue Nov 20, 2017
@MaximKudriavtsev
fix(react-grid): prevent click event propagation on detail toggle (#494)
f5b861b 
fixes #492
@dxrobot dxrobot added the Grid The DevExtreme Reactive Grid component label May 2, 2019
@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MaximKudriavtsev MaximKudriavtsev

Labels
bug Grid The DevExtreme Reactive Grid component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(react-grid): prevent click event propagation on detail toggle
4 participants
@kvet @dxrobot @MaximKudriavtsev @dmtrKovalenko