Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid - All rows are re-rendered when editing a row if VirtualTable is used #1925

Closed
2 tasks done
artem-kurchenko opened this issue Mar 20, 2019 · 2 comments · Fixed by #1959
Closed
2 tasks done

Grid - All rows are re-rendered when editing a row if VirtualTable is used #1925

artem-kurchenko opened this issue Mar 20, 2019 · 2 comments · Fixed by #1959
Labels

Comments

@artem-kurchenko
Copy link

  • I have searched this repository's issues and believe that this is not a duplicate.

I'm using ...

  • React Grid

Current Behaviour

Here are two sandbox demos:

  1. https://codesandbox.io/s/w215mo8j6k
  2. https://codesandbox.io/s/vvvx383800
    https://codesandbox.io/s/k36wqkw62v (Bootstrap 4)

Demo (1) uses the Table component and it only re-renders the edited row when you click save.
Demo (2) uses the VirtualTable component and it re-renders 12 rows on each input change.

Expected Behaviour

A single row should be re-rendered on editing if VirtualTable is used

Environment

  • devextreme-reactive: 1.10.4
  • react: 16.6
@SergeyAlexeev SergeyAlexeev self-assigned this Mar 20, 2019
@artem-kurchenko artem-kurchenko changed the title Grid - All rows are rendered when editing a row if VirtualTable is used Grid - All rows are re-rendered when editing a row if VirtualTable is used Mar 20, 2019
@SergeyAlexeev
Copy link
Contributor

Current progress:

We researched the problem and found that it doesn't appear if there is no seamless-immutable library. This sample shows it in action.
The seamless-immutable library can be removed from an initial sample, because we transform immutable entities into mutable ones, for example: editingRowIds.asMutable().

@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants