📌 Sticky columns: The row height changes when you select/focus/edit it #28412
+137
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raushen
force-pushed
the
Sticky_focus_borders_24_2
branch
from
ff0e940
to
ca2256d
Compare
| @@ -32,6 +32,7 @@ $generic-grid-base-checkbox-icon-size: 16px; | |||
| $generic-grid-base-checkbox-indeterminate-icon-size: 6px; | |||
| $grid-masterdetail-padding: 20px; | |||
| $generic-grid-base-group-panel-message-line-height: $generic-button-text-line-height; | |||
| $generic-grid-base-cell-input-height: round($generic-base-line-height * $generic-base-font-size) + 2 * $generic-grid-base-cell-padding; | |||
There was a problem hiding this comment.
What is 2? Would be great to have variable with appropriate name which describes the idea of the value, it will be especially useful for future code support.
There was a problem hiding this comment.
I extracted the variable with appropriate name from here. What is wrong? A height contains 2 paddings from top and bottom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.