Multi Provider #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ajwootto
commented
May 2, 2024
•
ajwootto
commented
- WIP draft of vendor migration / meta / multi / omega provider based on the original PR
| }; | ||
|
|
||
| export class MultiProvider implements Provider { | ||
| readonly runsOn = 'server'; |
There was a problem hiding this comment.
I guess this brings up the question (probably fo the OF folks), should this be named the ServerMultiProvider?
There was a problem hiding this comment.
that wouldn't match the other provider naming conventions used in this repo, where an "unqualified" name seems to be assumed to mean "server", and web providers add "web" to the name
| provider: Provider; | ||
| }; | ||
|
|
||
| export class MultiProvider implements Provider { |
There was a problem hiding this comment.
More general thoughts:
- Might need some object types to encapsulate passing around so many params between methods.
- Can or should the handler / status / hooks code be moved to other classes?
There was a problem hiding this comment.
not really sure about the status thing, it's pretty intertwined with the rest of what's in here so it might be kind of an unnecessary indirection to move it
There was a problem hiding this comment.
actually i tried moving it and it wasnt that bad
jonathannorris
approved these changes
May 23, 2024
ajwootto
force-pushed
the
ajwootto/meta-provider
branch
5 times, most recently
from
667c018
to
bb17e3f
Compare
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ajwootto
force-pushed
the
ajwootto/meta-provider
branch
5 times, most recently
from
2a8f2df
to
30245ad
Compare
Signed-off-by: Todd Baert <[email protected]>
ajwootto
force-pushed
the
ajwootto/meta-provider
branch
from
c0b15b0
to
bf161e0
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#920) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Adam Wootton <[email protected]>
Signed-off-by: Adam Wootton <[email protected]>
Signed-off-by: Adam Wootton <[email protected]>
Signed-off-by: Adam Wootton <[email protected]>
Signed-off-by: Adam Wootton <[email protected]>
Signed-off-by: Adam Wootton <[email protected]>
Signed-off-by: Adam Wootton <[email protected]>
ajwootto
force-pushed
the
ajwootto/meta-provider
branch
7 times, most recently
from
17d23f7
to
271ca0e
Compare
Signed-off-by: Adam Wootton <[email protected]>
ajwootto
force-pushed
the
ajwootto/meta-provider
branch
from
271ca0e
to
1b15cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.