Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 解决InputNumber数字输入框,去除掉值之后失焦/确认之后会变成数值0的问题。 #1849

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

aolinpk
Copy link
Contributor

@aolinpk aolinpk commented May 21, 2024

支持inputNumber可以允许输入空串值,即用户删除掉所有值之后有效 对应issues #1843

@aolinpk aolinpk changed the title #1843 解决InputNumber数字输入框,去除掉值之后失焦/确认之后会变成数值0的问题。 fix: 解决InputNumber数字输入框,去除掉值之后失焦/确认之后会变成数值0的问题。#1843 May 21, 2024
@aolinpk aolinpk changed the title fix: 解决InputNumber数字输入框,去除掉值之后失焦/确认之后会变成数值0的问题。#1843 fix: 解决InputNumber数字输入框,去除掉值之后失焦/确认之后会变成数值0的问题。 May 21, 2024
@GreatZPP
Copy link
Member

这里可以使用一个开关的形式

@GaoNeng-wWw
Copy link
Collaborator

也许做成一个props控制一下会更好

修复历史代码中为通过语法校验的语法错误。(formContext存在未被定义的情况无法通过ts语法校验)
Copy link

PR preview has been successfully built and deployed to https://vue-devui-pr-1849.surge.sh.

@aolinpk
Copy link
Contributor Author

aolinpk commented May 27, 2024

已经处理了,功能与官方Angular版本的参数和返回值一样。 并且顺便修复了一下历史文件中未通过ts校验的语法。(几处警告和一处报错。)

@aolinpk
Copy link
Contributor Author

aolinpk commented May 27, 2024

历史问题getPropsSlot函数不通过eslint的ts检查:getPropsSlot函数无需设置参数类型。

Copy link

PR preview has been successfully built and deployed to https://vue-devui-pr-1849.surge.sh.

@GaoNeng-wWw
Copy link
Collaborator

可以补充一下单元测试吗?

Copy link

PR preview has been successfully built and deployed to https://vue-devui-pr-1849.surge.sh.

Copy link

Deploy PR preview failed.

6 similar comments
Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

Copy link

Deploy PR preview failed.

@GreatZPP GreatZPP merged commit b4a3289 into DevCloudFE:dev Jun 3, 2024
1 of 2 checks passed
@GreatZPP GreatZPP added the feature New feature label Jun 3, 2024
@aolinpk aolinpk deleted the aolinpk/fix-inputNumber branch June 4, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants