Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature]: 希望action-timeline的icon可以支持插槽的形式嵌入 #1846

Closed
aolinpk opened this issue May 17, 2024 · 2 comments
Closed

Comments

@aolinpk
Copy link
Contributor

aolinpk commented May 17, 2024

What problem does this feature solve

项目中的图标不是伪类形式的,希望可以通过插槽的方式注入显示。目前组件已经开放了标题和内容的插槽建议也加入图标的插槽。
image

What does the proposed API look like

API name: iconContent

@aolinpk
Copy link
Contributor Author

aolinpk commented May 29, 2024

本周内会提交PR

aolinpk added a commit to aolinpk/vue-devui that referenced this issue May 31, 2024
GreatZPP pushed a commit that referenced this issue Jun 3, 2024
* feat(ActionTimeline): ActionTimeline组件新增自定义icon位置的内容插槽,未传入时默认使用原方式,对现有使用不影响。#1846

* feat(ActionTimeline): 删除多余的console #1846
@fu050409
Copy link
Collaborator

和此 issue 关联的 PR 已经被 Merge,故关闭此 issue。

另外,你可以依照 GitHub 的标准在你的 Pull Request 中的描述文本中加入Resolved #1880(也可以用FixResolves等关键字,参考 GitHub 官方教程)字样来链接你的 PR 和你解决的 issue,这样在 PR 被合并时 issue 会被一并关闭 :)

Originally posted by @fu050409 in #1880 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants