Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change codebase to TypeScript #14

Merged
merged 18 commits into from
Dec 19, 2019
Merged

change codebase to TypeScript #14

merged 18 commits into from
Dec 19, 2019

Conversation

miami78
Copy link
Collaborator

@miami78 miami78 commented Dec 16, 2019

What does this PR do?

change codebase to TypeScript

Description of Task to be completed?

Change the project to use TypeScript, configure typescript linting and testing with mocha-chai
solves #10 #13

Copy link
Contributor

@fatmali fatmali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job setting this up @miami78 ! I left a bunch of comments :-)

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/Utils/helper.ts Outdated Show resolved Hide resolved
src/controllers/eventController.ts Outdated Show resolved Hide resolved
src/routes/eventRoute.ts Outdated Show resolved Hide resolved
src/server.ts Outdated Show resolved Hide resolved
tslint.json Outdated Show resolved Hide resolved
src/routes/eventRoute.ts Outdated Show resolved Hide resolved
@MarvinKweyu MarvinKweyu mentioned this pull request Dec 17, 2019
1 task
Copy link
Member

@MarvinKweyu MarvinKweyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps take a look at the suggestions in event

src/DB/db.js Outdated Show resolved Hide resolved
Copy link
Member

@MarvinKweyu MarvinKweyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the array of objects in speaker

src/DB/db.js Outdated Show resolved Hide resolved
@fatmali fatmali marked this pull request as ready for review December 19, 2019 08:43
@fatmali fatmali merged commit f125d3f into DevCEldoret:development Dec 19, 2019
fatmali pushed a commit that referenced this pull request Dec 21, 2019
* typescript redo

* create event test

* move to typescript

* remove build folder

* typescript redo

* ignore build folder

* ignore build folder

* update draft pull request

* change route entrypoint

* change route

* add event description

* schema change

* change from class to function

* get event query test

* fix getevent model

* add event test

* change to class
fatmali pushed a commit that referenced this pull request Jan 9, 2020
* typescript redo

* create event test

* move to typescript

* remove build folder

* typescript redo

* ignore build folder

* ignore build folder

* update draft pull request

* change route entrypoint

* change route

* add event description

* schema change

* change from class to function

* get event query test

* fix getevent model

* add event test

* change to class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants