-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale detection and language selection #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… success toast on success
…ction-and-language-selection by @TadeSF branch: locale-detection-and-language-selection
…option for selecting language / Local Storing of current theme preferance branch: locale-detection-and-language-selection
branch: locale-detection-and-language-selection
branch: locale-detection-and-language-selection
…log to make linter test pass branch: locale-detection-and-language-selection
This reverts commit 51ceeef.
This reverts commit 95c04e6.
…console.log to make linter test pass" This reverts commit 4920427.
…log to make linter test pass branch: locale-detection-and-language-selection
branch: locale-detection-and-language-selection
branch: locale-detection-and-language-selection
Strehk
commented
Jul 9, 2023
branch: locale-detection-and-language-selection
branch: locale-detection-and-language-selection
m1212e
reviewed
Jul 9, 2023
m1212e
reviewed
Jul 9, 2023
m1212e
reviewed
Jul 9, 2023
m1212e
reviewed
Jul 9, 2023
m1212e
reviewed
Jul 9, 2023
m1212e
requested changes
Jul 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add i18n
branch: locale-detection-and-language-selection
m1212e
approved these changes
Jul 10, 2023
Strehk
added a commit
that referenced
this pull request
Jul 10, 2023
* 📚 docs (contributions): VS Code Extension Recommendation – Commit Messages Template (#43) * 📚 docs (contributions): VS Code Extension Recommendation by @TadeSF branch: vs-code-commit-extension * 🧼 format & lint (MUNify) by @TadeSF branch: vs-code-commit-extension * 🧹 chore (MUNify): add git commit config to vcs branch: vs-code-commit-extension * 📚 docs (MUNify): Contributing Update branch: vs-code-commit-extension * 📚 docs (MUNify): Contributing Update branch: vs-code-commit-extension * 📚 docs (MUNify): Contributing Update branch: vs-code-commit-extension --------- Co-authored-by: m1212e <[email protected]> * Locale detection and language selection (#45) * 🐞 fix: Fix title in base layout * ✨feature: Chair Page Setup, Navigation and Speakers List * ✨feature: Attendance Page * ✨feature: i18n * ✨feature: Whiteboard Update and Chair Editing Support * 🐞 fix: Formatting * 🔵 other: Color Pallet update * 🐞 fix: any -> unknown * 📄 docs: Clearer Documentation * ✨feature: Dark Mode * ✨feature: System Color Mode detection & High Contrast Mode * ✨feature: Changing Speech times * ✨feature: Navbar Button Titles & New Chair Presentation Window Button in Navbar * ✨feature: Navbar Button Titles & New Chair Presentation Window Button in Navbar * 🐞 fix: Few Theme related design changes * ✨feature: Fuse.js Fuzzy Search for Countries * ✨feature: Add Country to List Toast and other minor changes * ✨feature: Change Speakers Time: Show warning if wrong format and show success toast on success * ✨feature: Chair Voting Page * 🐞 fix: I18n Type Error fix * 🐞 fix: I18n Type Error fix * 🐞 fix: install fuse in the frontend project * ✨ feat (CHASE Frontend): Local Storage Locale Detection and Settings option for selecting language / Local Storing of current theme preferance branch: locale-detection-and-language-selection * 🧼 format & lint (CHASE Frontend) branch: locale-detection-and-language-selection * 🐞 fix (CHASE Frontend): Window Build Error branch: locale-detection-and-language-selection * 🧼 format & lint (CHASE Frontend): Removing (or ignoring) all console.log to make linter test pass branch: locale-detection-and-language-selection * Revert "🐞 fix (CHASE Frontend): Window Build Error" This reverts commit 51ceeef. * Revert "Revert "🐞 fix (CHASE Frontend): Window Build Error"" This reverts commit 95c04e6. * Revert "🧼 format & lint (CHASE Frontend): Removing (or ignoring) all console.log to make linter test pass" This reverts commit 4920427. * 🧼 format & lint (CHASE Frontend): Removing (or ignoring) all console.log to make linter test pass branch: locale-detection-and-language-selection * 🐞 fix (CHASE Frontend): using useState and useEffect in layout file branch: locale-detection-and-language-selection * 🐞 fix (CHASE-Frontend): SSR and localStorage branch: locale-detection-and-language-selection * 🧼 format & lint (CHASE-Frontend): lint branch: locale-detection-and-language-selection * 🐞 fix (CHASE-Frontend): Adding Localisation branch: locale-detection-and-language-selection --------- Co-authored-by: m1212e <[email protected]> * Update README.md --------- Co-authored-by: m1212e <[email protected]>
Strehk
added a commit
that referenced
this pull request
Jul 13, 2023
* fix: make layout client component * Main Update (#49) * 📚 docs (contributions): VS Code Extension Recommendation – Commit Messages Template (#43) * 📚 docs (contributions): VS Code Extension Recommendation by @TadeSF branch: vs-code-commit-extension * 🧼 format & lint (MUNify) by @TadeSF branch: vs-code-commit-extension * 🧹 chore (MUNify): add git commit config to vcs branch: vs-code-commit-extension * 📚 docs (MUNify): Contributing Update branch: vs-code-commit-extension * 📚 docs (MUNify): Contributing Update branch: vs-code-commit-extension * 📚 docs (MUNify): Contributing Update branch: vs-code-commit-extension --------- Co-authored-by: m1212e <[email protected]> * Locale detection and language selection (#45) * 🐞 fix: Fix title in base layout * ✨feature: Chair Page Setup, Navigation and Speakers List * ✨feature: Attendance Page * ✨feature: i18n * ✨feature: Whiteboard Update and Chair Editing Support * 🐞 fix: Formatting * 🔵 other: Color Pallet update * 🐞 fix: any -> unknown * 📄 docs: Clearer Documentation * ✨feature: Dark Mode * ✨feature: System Color Mode detection & High Contrast Mode * ✨feature: Changing Speech times * ✨feature: Navbar Button Titles & New Chair Presentation Window Button in Navbar * ✨feature: Navbar Button Titles & New Chair Presentation Window Button in Navbar * 🐞 fix: Few Theme related design changes * ✨feature: Fuse.js Fuzzy Search for Countries * ✨feature: Add Country to List Toast and other minor changes * ✨feature: Change Speakers Time: Show warning if wrong format and show success toast on success * ✨feature: Chair Voting Page * 🐞 fix: I18n Type Error fix * 🐞 fix: I18n Type Error fix * 🐞 fix: install fuse in the frontend project * ✨ feat (CHASE Frontend): Local Storage Locale Detection and Settings option for selecting language / Local Storing of current theme preferance branch: locale-detection-and-language-selection * 🧼 format & lint (CHASE Frontend) branch: locale-detection-and-language-selection * 🐞 fix (CHASE Frontend): Window Build Error branch: locale-detection-and-language-selection * 🧼 format & lint (CHASE Frontend): Removing (or ignoring) all console.log to make linter test pass branch: locale-detection-and-language-selection * Revert "🐞 fix (CHASE Frontend): Window Build Error" This reverts commit 51ceeef. * Revert "Revert "🐞 fix (CHASE Frontend): Window Build Error"" This reverts commit 95c04e6. * Revert "🧼 format & lint (CHASE Frontend): Removing (or ignoring) all console.log to make linter test pass" This reverts commit 4920427. * 🧼 format & lint (CHASE Frontend): Removing (or ignoring) all console.log to make linter test pass branch: locale-detection-and-language-selection * 🐞 fix (CHASE Frontend): using useState and useEffect in layout file branch: locale-detection-and-language-selection * 🐞 fix (CHASE-Frontend): SSR and localStorage branch: locale-detection-and-language-selection * 🧼 format & lint (CHASE-Frontend): lint branch: locale-detection-and-language-selection * 🐞 fix (CHASE-Frontend): Adding Localisation branch: locale-detection-and-language-selection --------- Co-authored-by: m1212e <[email protected]> * Update README.md --------- Co-authored-by: m1212e <[email protected]> * 🐞 fix (CHASE Frontend): i18n branch: 41-i18n-context-not-working-in-layout-components --------- Co-authored-by: m1212e <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements preferred locale loading based on local storage data, as well as the ability for the unser to select the language against the browser preferred settings.
Also, the users theme preferences will now be stored as well and won't be lost if the page is reloaded.