Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ improvement (CHASE Frontend): Update password regex to allow more flexibility and allow more special characters #129

Merged
merged 2 commits into from
Mar 20, 2024
Merged

⬆️ improvement (CHASE Frontend): Update password regex to allow more flexibility and allow more special characters #129

merged 2 commits into from
Mar 20, 2024

Conversation

Strehk
Copy link
Member

@Strehk Strehk commented Mar 18, 2024

branch: 128-password-regex-strong-but-provides-very-little-flexibility

@Strehk
⬆️ improvement (CHASE Frontend): Update password regex to allow more …
73a8a58 
…flexibility and allow more special characters

branch: 128-password-regex-strong-but-provides-very-little-flexibility
@Strehk Strehk linked an issue Mar 18, 2024 that may be closed by this pull request
Password REGEX strong, but provides very little flexibility #128
Closed
@Strehk
🧼 format & lint (CHASE Backend):
8d53a81 
branch: 128-password-regex-strong-but-provides-very-little-flexibility
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 18, 2024
View reviewed changes
chase/frontend/app/(pages)/login/createCredentials/page.tsx Dismissed Show dismissed Hide dismissed
chase/frontend/app/(pages)/login/createCredentials/page.tsx Dismissed Show dismissed Hide dismissed
chase/frontend/app/(pages)/login/createCredentials/page.tsx Dismissed Show dismissed Hide dismissed
chase/frontend/app/(pages)/login/createCredentials/page.tsx Dismissed Show dismissed Hide dismissed
chase/backend/src/routes/auth/passwords.ts Dismissed Show dismissed Hide dismissed
chase/backend/src/routes/auth/passwords.ts Dismissed Show dismissed Hide dismissed
chase/backend/src/routes/auth/passwords.ts Dismissed Show dismissed Hide dismissed
chase/backend/src/routes/auth/passwords.ts Dismissed Show dismissed Hide dismissed
@Strehk
Copy link
Member Author

Strehk commented Mar 18, 2024

@m1212e any Idea if this CodeQL warning is relevant? The asterisk was like this before, so I guess you initially ignored this warning as well?

@Strehk Strehk requested a review from m1212e March 18, 2024 15:33
@m1212e
Copy link
Member

m1212e commented Mar 19, 2024

I did not explicitly ignore the warning, I guess the ql task never ran the code. Did you change it yourself or pick it up from the internet?

@Strehk
Copy link
Member Author

Strehk commented Mar 19, 2024

I got it from here:
https://stackoverflow.com/questions/5142103/regex-to-validate-password-strength

The second comment, because it looked cleaner then the first one

@m1212e
Copy link
Member

m1212e commented Mar 19, 2024

Yeah, in case of random folks on the internet verifying that the pattern is good, we can safely ignore the ql issues

@Strehk Strehk merged commit eb352d6 into main Mar 20, 2024
6 checks passed
@Strehk Strehk deleted the 128-password-regex-strong-but-provides-very-little-flexibility branch March 20, 2024 10:29
m1212e added a commit that referenced this pull request Apr 1, 2024
@m1212e
Squashed commit of the following:
dbfef8f 
commit 9a0d1fb
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 25 12:04:40 2024 +0100

    ⬆️ improvement (CHASE Frontend): Grand restructuring and stylisitic overhaul of the Admin Config Pages to make them feel more belonging to the rest of the app (#141)

    * 🧹 chore (CHASE Frontend): add a prisma path alias
    branch: restyle-admin-pages

    * ⬆️ improvement (CHASE Frontend): Reorganize admin pages in directory structure
    branch: restyle-admin-pages

    * ⬆️ improvement (CHASE Frontend): Remake of Admin Page Layouts (no onboarding, rather normal menu)
    branch: restyle-admin-pages

commit 402ed83
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 25 11:59:21 2024 +0100

    🎨 style (CHASE Frontend): Establish tailwind plugin class "pophover" for unified pop-effect and added Mission Control Icon for better recogition (#140)

    * 🎨 style (CHASE Frontend): Establish tailwind plugin class "pophover" for unified pop-effect
    branch: small-style-improvements

    * 🎨 style (CHASE Frontend): added Mission control Icon
    branch: small-style-improvements

commit e912123
Author: Tade Strehk <[email protected]>
Date:   Sat Mar 23 11:48:00 2024 +0100

    ✨ feat (CHASE Frontend): Handle Security Council Edge Case, where the simple majority is always set to a static 9 votes, not 8 (15/2) (#139)

    * ✨ feat (CHASE Frontend): Handle Security Council Edge Case, where the simple majority is always set to a static 9 votes, not 8 (15/2)
    branch: 124-security-council-majority-edge-case

    * 🚧 wip (CHASE Frontend): Add TODO tag
    branch: 124-security-council-majority-edge-case

commit 4825914
Author: Tade Strehk <[email protected]>
Date:   Wed Mar 20 13:16:10 2024 +0100

    🐞 fix (CHASE Frontend): Reference Serif Font Vollkorn correctly on landing page (#138)

    * 🧹 chore (CHASE Frontend): Remove unused google font files from repository
    branch: 137-wrong-serif-font-reference-throughout-the-app

    * 🐞 fix (CHASE Frontend): Reference Serif Font Vollkorn correctly on landing page
    branch: 137-wrong-serif-font-reference-throughout-the-app

commit eb352d6
Author: Tade Strehk <[email protected]>
Date:   Wed Mar 20 11:29:30 2024 +0100

    ⬆️ improvement (CHASE Frontend): Update password regex to allow more flexibility and allow more special characters (#129)

    * ⬆️ improvement (CHASE Frontend): Update password regex to allow more flexibility and allow more special characters
    branch: 128-password-regex-strong-but-provides-very-little-flexibility

    * 🧼 format & lint (CHASE Backend):
    branch: 128-password-regex-strong-but-provides-very-little-flexibility

commit 9a3da0b
Author: m1212e <[email protected]>
Date:   Tue Mar 19 19:53:25 2024 +0100

    Update README.md (#136)

commit b7171bc
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:49:53 2024 +0100

    🎨 style (CHASE Frontend): Fix UI styling issues in mission control and other small stylistic changes (#133)

    * 🎨 style (CHASE Frontend): Fix UI styling issues in mission control
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🎨 style (CHASE Frontend): Add text-center class to TimerWidget div
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🗺️ i18n (CHASE Frontend): Change "Team Hub" to "Mission Control"
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🧹 chore (MUNify): Add i18n to commit templates
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🎨 style (CHASE Frontend): Change Navbar Spacing and correct wrong i18n reference
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

commit b5837f1
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:49:30 2024 +0100

    ✨ feat (CHASE Frontend): Presentation mode Zoom/Scaling Buttons with document rem (#134)

    * ✨ feat (CHASE Frontend): Presentation mode Zoom/Scaling Buttons with document rem
    branch: 121-buttons-to-change-font-size-in-presentation-mode

    * 🐞 fix (CHASE Frontend): Update flag for United Kingdom
    branch: 121-buttons-to-change-font-size-in-presentation-mode

    * 🎨 style (CHASE Frontend): Update flag template dimensions
    branch: 121-buttons-to-change-font-size-in-presentation-mode

commit ec6528f
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:48:57 2024 +0100

    🐞 fix (CHASE Frontend): Fix Font Integration with NextJS (#135)

    * 🐞 fix (CHASE Frontend): Fix Font Integration with NextJS
    branch: 88-font-vollkorn-not-hosted

    * 🐞 fix (CHASE Frontend): Eliminate all preconfigured Fonts from Primereact Components
    branch: 88-font-vollkorn-not-hosted

    * 🐞 fix (CHASE Frontend): Small alignment issue
    branch: 88-font-vollkorn-not-hosted

    * 🎨 style (CHASE Frontend): Change base Sans-Serif font to Inter, less exhilarating, more calm and professional
    branch: 88-font-vollkorn-not-hosted

    * 🧼 format & lint (CHASE Frontend):
    branch: 88-font-vollkorn-not-hosted

commit 5224734
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:48:14 2024 +0100

    📚 docs (MUNify): Update Project READMEs (#132)

    branch: update-readme

commit be4fef8
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 11:04:48 2024 +0100

    🐞 fix (CHASE Frontend): add disable/enable toasts on certain pages (e.g. the presentation mode page) (#130)

    branch: 115-surpress-toastsnotifications-on-presentation-view

commit 6578315
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 11:04:29 2024 +0100

    ⬆️ improvement (CHASE Frontend): Sync Nation Names in German to DMUN Database (to match names printed on placards) (#131)

    * 🚧 wip (CHASE Frontend): Add nations data to json files
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * ⬆️ improvement (CHASE Frontend): Sync Nation Names in German to DMUN Database (to match names printed on placards)
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * 🧹 chore (CHASE Frontend): added syncing script and DMUN Database export from 2024/03/18 for later use
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * 🐞 fix (CHASE Frontend): Update data sources for non-state actors and special persons
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * 🧼 format & lint (CHASE Frontend):
    branch: 119-greman-country-names-compare-to-given-dmun-database

commit 9712abd
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 18 16:12:38 2024 +0100

    ✨ feat (CHASE Frontend): Update whiteboardContent default value to "Willkommen!" (#126)

    branch: 120-change-whiteboard-default-text

commit 95bf182
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 18 16:12:26 2024 +0100

    ✨ feat (CHASE Frontend): Add Speakers Time Reference and increase font size for Country and Speakers Time (#127)

    branch: 118-show-current-speaking-time-as-reference

commit 5d1b82f
Author: Tade Strehk <[email protected]>
Date:   Sun Mar 17 15:24:17 2024 +0100

    Create feature_request.md
Strehk added a commit that referenced this pull request May 5, 2024
@m1212e @Strehk
⬆️ improvement (CHASE Backend): Auth Rework, Backend cleanup and refa…
47d8f0a 
…ctoring

* 🚧 wip (CHASE Backend): rust backend setup
branch: rustify

* 🚧 wip (CHASE Backend): rust example
branch: rustify

* ✨ feat: switch to axum and configure graphql and subs correctly

* 🚧 wip (CHASE Backend): wip rust rework
branch: rustify

* ✨ feat (CHASE Backend): use nullable version of prismabox
branch: Branch not found

* 🚧 wip (CHASE Backend): bun memory research
branch: update-chores

* 🚧 wip (MUNify):
branch: update-chores

* ✨ feat (CHASE Backend): working backend
branch: update-chores

* 🔤 typing (CHASE Backend): fix correct bun imports
branch: update-chores

* 🐞 fix (CHASE Frontend): type errors & linter
branch: update-chores

* Squashed commit of the following:

commit 9a0d1fb
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 25 12:04:40 2024 +0100

    ⬆️ improvement (CHASE Frontend): Grand restructuring and stylisitic overhaul of the Admin Config Pages to make them feel more belonging to the rest of the app (#141)

    * 🧹 chore (CHASE Frontend): add a prisma path alias
    branch: restyle-admin-pages

    * ⬆️ improvement (CHASE Frontend): Reorganize admin pages in directory structure
    branch: restyle-admin-pages

    * ⬆️ improvement (CHASE Frontend): Remake of Admin Page Layouts (no onboarding, rather normal menu)
    branch: restyle-admin-pages

commit 402ed83
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 25 11:59:21 2024 +0100

    🎨 style (CHASE Frontend): Establish tailwind plugin class "pophover" for unified pop-effect and added Mission Control Icon for better recogition (#140)

    * 🎨 style (CHASE Frontend): Establish tailwind plugin class "pophover" for unified pop-effect
    branch: small-style-improvements

    * 🎨 style (CHASE Frontend): added Mission control Icon
    branch: small-style-improvements

commit e912123
Author: Tade Strehk <[email protected]>
Date:   Sat Mar 23 11:48:00 2024 +0100

    ✨ feat (CHASE Frontend): Handle Security Council Edge Case, where the simple majority is always set to a static 9 votes, not 8 (15/2) (#139)

    * ✨ feat (CHASE Frontend): Handle Security Council Edge Case, where the simple majority is always set to a static 9 votes, not 8 (15/2)
    branch: 124-security-council-majority-edge-case

    * 🚧 wip (CHASE Frontend): Add TODO tag
    branch: 124-security-council-majority-edge-case

commit 4825914
Author: Tade Strehk <[email protected]>
Date:   Wed Mar 20 13:16:10 2024 +0100

    🐞 fix (CHASE Frontend): Reference Serif Font Vollkorn correctly on landing page (#138)

    * 🧹 chore (CHASE Frontend): Remove unused google font files from repository
    branch: 137-wrong-serif-font-reference-throughout-the-app

    * 🐞 fix (CHASE Frontend): Reference Serif Font Vollkorn correctly on landing page
    branch: 137-wrong-serif-font-reference-throughout-the-app

commit eb352d6
Author: Tade Strehk <[email protected]>
Date:   Wed Mar 20 11:29:30 2024 +0100

    ⬆️ improvement (CHASE Frontend): Update password regex to allow more flexibility and allow more special characters (#129)

    * ⬆️ improvement (CHASE Frontend): Update password regex to allow more flexibility and allow more special characters
    branch: 128-password-regex-strong-but-provides-very-little-flexibility

    * 🧼 format & lint (CHASE Backend):
    branch: 128-password-regex-strong-but-provides-very-little-flexibility

commit 9a3da0b
Author: m1212e <[email protected]>
Date:   Tue Mar 19 19:53:25 2024 +0100

    Update README.md (#136)

commit b7171bc
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:49:53 2024 +0100

    🎨 style (CHASE Frontend): Fix UI styling issues in mission control and other small stylistic changes (#133)

    * 🎨 style (CHASE Frontend): Fix UI styling issues in mission control
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🎨 style (CHASE Frontend): Add text-center class to TimerWidget div
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🗺️ i18n (CHASE Frontend): Change "Team Hub" to "Mission Control"
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🧹 chore (MUNify): Add i18n to commit templates
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

    * 🎨 style (CHASE Frontend): Change Navbar Spacing and correct wrong i18n reference
    branch: 125-restrict-number-of-letters-for-statuses-so-that-everything-is-displayed

commit b5837f1
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:49:30 2024 +0100

    ✨ feat (CHASE Frontend): Presentation mode Zoom/Scaling Buttons with document rem (#134)

    * ✨ feat (CHASE Frontend): Presentation mode Zoom/Scaling Buttons with document rem
    branch: 121-buttons-to-change-font-size-in-presentation-mode

    * 🐞 fix (CHASE Frontend): Update flag for United Kingdom
    branch: 121-buttons-to-change-font-size-in-presentation-mode

    * 🎨 style (CHASE Frontend): Update flag template dimensions
    branch: 121-buttons-to-change-font-size-in-presentation-mode

commit ec6528f
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:48:57 2024 +0100

    🐞 fix (CHASE Frontend): Fix Font Integration with NextJS (#135)

    * 🐞 fix (CHASE Frontend): Fix Font Integration with NextJS
    branch: 88-font-vollkorn-not-hosted

    * 🐞 fix (CHASE Frontend): Eliminate all preconfigured Fonts from Primereact Components
    branch: 88-font-vollkorn-not-hosted

    * 🐞 fix (CHASE Frontend): Small alignment issue
    branch: 88-font-vollkorn-not-hosted

    * 🎨 style (CHASE Frontend): Change base Sans-Serif font to Inter, less exhilarating, more calm and professional
    branch: 88-font-vollkorn-not-hosted

    * 🧼 format & lint (CHASE Frontend):
    branch: 88-font-vollkorn-not-hosted

commit 5224734
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 19:48:14 2024 +0100

    📚 docs (MUNify): Update Project READMEs (#132)

    branch: update-readme

commit be4fef8
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 11:04:48 2024 +0100

    🐞 fix (CHASE Frontend): add disable/enable toasts on certain pages (e.g. the presentation mode page) (#130)

    branch: 115-surpress-toastsnotifications-on-presentation-view

commit 6578315
Author: Tade Strehk <[email protected]>
Date:   Tue Mar 19 11:04:29 2024 +0100

    ⬆️ improvement (CHASE Frontend): Sync Nation Names in German to DMUN Database (to match names printed on placards) (#131)

    * 🚧 wip (CHASE Frontend): Add nations data to json files
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * ⬆️ improvement (CHASE Frontend): Sync Nation Names in German to DMUN Database (to match names printed on placards)
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * 🧹 chore (CHASE Frontend): added syncing script and DMUN Database export from 2024/03/18 for later use
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * 🐞 fix (CHASE Frontend): Update data sources for non-state actors and special persons
    branch: 119-greman-country-names-compare-to-given-dmun-database

    * 🧼 format & lint (CHASE Frontend):
    branch: 119-greman-country-names-compare-to-given-dmun-database

commit 9712abd
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 18 16:12:38 2024 +0100

    ✨ feat (CHASE Frontend): Update whiteboardContent default value to "Willkommen!" (#126)

    branch: 120-change-whiteboard-default-text

commit 95bf182
Author: Tade Strehk <[email protected]>
Date:   Mon Mar 18 16:12:26 2024 +0100

    ✨ feat (CHASE Frontend): Add Speakers Time Reference and increase font size for Country and Speakers Time (#127)

    branch: 118-show-current-speaking-time-as-reference

commit 5d1b82f
Author: Tade Strehk <[email protected]>
Date:   Sun Mar 17 15:24:17 2024 +0100

    Create feature_request.md

* 🧼 format & lint (CHASE Frontend):
branch: update-chores

* 🧼 format & lint (CHASE Frontend):
branch: update-chores

* 🐞 fix (CHASE Backend): cicd errors
branch: update-chores

* 🐞 fix (CHASE Frontend): linter
branch: update-chores

* 🐞 fix (CHASE Backend): explicitly set cookie options
branch: update-chores

* 🚧 wip (CHASE Frontend):
branch: Branch not found

* 🚧 wip (CHASE Frontend): treaty fixes
branch: better-frontend-hooks

* 🐞 fix (CHASE Frontend): finalize type fixes
branch: better-frontend-hooks

* 🔤 typing (CHASE Backend): remove unused import
branch: update-chores

* ♻️ refactor (MUNify):
branch: Branch not found

* 🚧 wip (CHASE Backend)

* ✨ feat (CHASE Backend): rework conference endpoints
branch: auth-rework-and-refactoring

* ✨ feat (CHASE Backend): add response to conference delete
branch: auth-rework-and-refactoring

* 🚧 wip:
branch: auth-rework-and-refactoring

* 🚧 wip (CHASE Backend):
branch: auth-rework-and-refactoring

* ✨ feat (CHASE Backend): add permission checks to endpoints
branch: auth-rework-and-refactoring

* 🚧 wip (MUNify):
branch: auth-rework-and-refactoring

* ♻️ refactor (CHASE Frontend): finalize api cleanup
branch: auth-rework-and-refactoring

* Co-authored-by: Tade Strehk <[email protected]>
✨ feat (CHASE Backend): define specific abilities for various entities
branch: auth-rework-and-refactoring

* 🐞 fix (CHASE Backend): type errors
branch: auth-rework-and-refactoring

* 🐞 fix (CHASE Backend): remove strong response types
branch: auth-rework-and-refactoring

* 🐞 fix (CHASE Backend): type errors
branch: auth-rework-and-refactoring

* 🐞 fix (CHASE Backend): remove response filters
branch: auth-rework-and-refactoring

* 🐞 fix (App Frontend): Fix fronted bugs after backend rework and lint
branch: auth-rework-and-refactoring

* ✨ feat (CHASE Backend): temp wildcard permissions
branch: auth-rework-and-refactoring

* 🔤 typing (App Backend): Fix Typecheck errors (unused variables)
branch: auth-rework-and-refactoring

---------

Co-authored-by: Tade Strehk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1212e m1212e m1212e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password REGEX strong, but provides very little flexibility
2 participants
@Strehk @m1212e