Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on SUIS #941

Merged
merged 21 commits into from
May 3, 2024
Merged

Error on SUIS #941

merged 21 commits into from
May 3, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 22, 2024

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc added upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing MacOS Darwin/MacOS labels Apr 22, 2024
@grahamc grahamc closed this Apr 22, 2024
@grahamc grahamc reopened this Apr 22, 2024
cole-h
cole-h reviewed Apr 22, 2024
View reviewed changes
src/planner/macos/mod.rs Outdated Show resolved Hide resolved
src/planner/macos/mod.rs Outdated Show resolved Hide resolved
src/planner/macos/mod.rs Outdated Show resolved Hide resolved
src/planner/macos/profiles.rs Outdated Show resolved Hide resolved
src/planner/macos/profile_queries.rs Outdated Show resolved Hide resolved
src/planner/macos/profiles.rs Outdated Show resolved Hide resolved
src/planner/macos/profile_queries.rs Outdated Show resolved Hide resolved
cole-h
cole-h reviewed May 2, 2024
View reviewed changes
src/planner/macos/mod.rs Outdated Show resolved Hide resolved
@grahamc grahamc merged commit 70a6159 into main May 3, 2024
12 checks passed
@grahamc grahamc deleted the error-suis branch May 3, 2024 01:13
@cole-h cole-h added this to the 0.19.0 milestone May 3, 2024
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
MacOS Darwin/MacOS upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @cole-h