Move all CI to GitHub Actions #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
added
upload to s3
cole-h
added
upload to s3
cole-h
changed the title
cole-h
added
upload to s3
edolstra
approved these changes
Apr 9, 2024
This comment was marked as resolved.
This comment was marked as resolved.
As awesome as Buildkite is, it is unfortunately not useful for this setup: * We use Buildkite to build installer binaries * We then use GitHub Actions to run the installer binaries on a host without Nix already installed We don't use Buildkite for both steps because setting up agents to install Nix on would be a pain, as erasing everything takes a while. This is preparation for using GitHub Actions for everything in our CI pipeline, as it is much faster and we don't need to worry about keeping the runners running ourselves (there have been times where our Buildkite agents were unreachable for some reason or another).
So that when I go to fix the releases action, it will be easier to reuse.
There are no GitHub Actions that make it easy to wait for another workflow to complete :/
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Buildkite is awesome, but makes it difficult to accept PRs from external contributors (the action we were using to wait for Buildkite to complete requires a token secret, and we don't allow external contributors to have access to it, causing CI to not do anything useful for them). By moving CI to run entirely in GitHub Actions, it becomes much easier to accept external contributions.
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: