Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding the Nix installer in the binary. #897

Merged
merged 11 commits into from
May 2, 2024
Merged

Embedding the Nix installer in the binary. #897

merged 11 commits into from
May 2, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Mar 21, 2024

Description

Embedding the Nix binary will reduce runtime failures due to fetching, and reduce the foundation's bandwidth burden by roughly half a terabyte per day.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Mar 24, 2024
@grahamc grahamc closed this Mar 24, 2024
@grahamc grahamc reopened this Mar 24, 2024
@grahamc grahamc changed the title Upgrade to Nix 2.21.0, while also embedding the Nix installer in the binary. Embedding the Nix installer in the binary. Mar 24, 2024
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
@ShalokShalom
Copy link

I guess its too early for that, but I would personally love to see the option to use tvix.

This improves built-in offline support, and improves install time reliability.
src/settings.rs Show resolved Hide resolved
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyewl.

@cole-h cole-h merged commit 3ec6c32 into main May 2, 2024
6 of 12 checks passed
@cole-h cole-h deleted the embed-nix branch May 2, 2024 16:31
@cole-h
Copy link
Member

cole-h commented May 2, 2024

@ShalokShalom

I guess its too early for that, but I would personally love to see the option to use tvix.

I'm also interested in tvix, but I don't think we would even consider supporting it in this project until it supported flakes. Maybe this has changed recently, but I also remember last time I checked on it, it didn't support building and/or substituting, which makes for a very limited Nix experience 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants