Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify shell profile files if they are symlinks #767

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Don't modify shell profile files if they are symlinks #767

merged 2 commits into from
Dec 5, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Should address #721.

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.15.2 milestone Dec 4, 2023
@Hoverbear Hoverbear self-assigned this Dec 4, 2023
@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Dec 4, 2023
grahamc
grahamc approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hoverbear Hoverbear merged commit b84ebf0 into main Dec 5, 2023
13 checks passed
@Hoverbear Hoverbear deleted the hoverbear/fh-86-dont-do-shell-profile-recovery-if-files-are-symlinks branch December 5, 2023 19:14
@cole-h cole-h mentioned this pull request Jan 6, 2024
Closed
@cole-h cole-h mentioned this pull request Apr 15, 2024
Closed
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees

@Hoverbear Hoverbear

Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @grahamc