Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit code inconsistency #684

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix exit code inconsistency #684

merged 1 commit into from
Oct 23, 2023

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Oct 23, 2023 •
edited
Loading

Description

As noted in #653 (comment)

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.14.1 milestone Oct 23, 2023
@Hoverbear Hoverbear self-assigned this Oct 23, 2023
@Hoverbear Hoverbear merged commit 2dd4081 into main Oct 23, 2023
13 checks passed
@Hoverbear Hoverbear deleted the hoverbear/ds-1279-when-install-script-fails-it-should-exit-with-non-0-error branch October 23, 2023 20:52
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h